rustc_session; remove rustc_lint_defs re-exports - #161043
Conversation
|
Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer Some changes occurred in match checking cc @Nadrieril Some changes occurred in src/tools/cargo cc @weihanglo These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred in exhaustiveness checking cc @Nadrieril Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt The parser was modified, potentially altering the grammar of (stable) Rust cc @fmease Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr HIR ty lowering was modified cc @fmease Some changes occurred to the CTFE machinery
cc @rust-lang/clippy Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
rustbot
added
A-attributes
|
r? @camelid rustbot has assigned @camelid. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
mejrs
changed the title
This comment has been minimized.
This comment has been minimized.
1b244b9 to
a088f89
Compare
This comment has been minimized.
This comment has been minimized.
a088f89 to
ff2853d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| use rustc_abi::Size; | ||
| use rustc_crate_store::{self as cstore, CrateSource}; | ||
| use rustc_crate_store::{self as cstore, self, CrateSource}; |
There was a problem hiding this comment.
Why did you add a duplicate self import?
There was a problem hiding this comment.
oops, that's just me adding a new import without noticing that was already there, and then rustfmt merging the two.
| use rustc_hir::intravisit::FnKind as HirFnKind; | ||
| use rustc_hir::{self as hir, Body, FnDecl, ImplItemImplKind, PatKind, PredicateOrigin, find_attr}; | ||
| // Lints from rustc_lint_defs | ||
| pub use rustc_lint_defs::builtin::*; |
There was a problem hiding this comment.
Assuming you're planning to remove this in a future PR? (Thanks for not making this one even bigger by doing it haha)
| pub use rustc_lint_defs::Level::{self, *}; | ||
| pub use rustc_lint_defs::{ | ||
| Applicability, FutureIncompatibleInfo, Lint, LintId, LintPass, LintVec, declare_lint, | ||
| declare_lint_pass, declare_tool_lint, impl_lint_pass, | ||
| }; |
There was a problem hiding this comment.
Why did you add new re-exports here?
There was a problem hiding this comment.
So that tools like rustcdoc and clippy can just import from rustc_lint, I think it's nice to have everything those tools need importable from one place. this is also the reason for the pub use rustc_lint_defs::builtin::*; above.
d71a3a8 to
c69420b
Compare
This comment has been minimized.
This comment has been minimized.
c69420b to
3b5eaaa
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3b8c5d3 to
20d3428
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r+ p=1 note="very merge conflict-prone" |
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 8925ea3 (parent) -> 095d9ef (this PR) Test differencesShow 368 test diffs368 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 095d9ef41e2360afb04faef48d2fdca76a9a2992 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (095d9ef): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -2.1%, secondary 3.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -5.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 456.865s -> 456.409s (-0.10%) |
7 participants
View all comments
Some crates and tools were depending on just rustc_session for its re-exporting of an entire crate.
rustc_lint still re-exports rustc_lint_defs; that one would have been rather messy to remove because a lot of modules in clippy/rustdoc would have to import some from one and some from the other.