Clippy subtree update by flip1995 · Pull Request #161416 · rust-lang/rust

flip1995 · 2026-08-20T17:53:16Z

r? Manishearth

Cargo.lock update due to Clippy version bump

This has multiple advantages: - Performance. The new type is 1/3 the size of `Vec` (being equivalent in layout to `Option<ThinVec>`) and can be kept in a register. - Type safety. We mark the type `#[must_use]`, and thinks requiring errors take `ThinVec`, which requires unwrapping the type and verifying there is indeed an error. We still provide conversions to slices, `ThinVec`, and iteration, because some code needs this and I saw no benefit in changing it, but we deliberately do not provide `Deref<Target = [E]>` or things like that.

…ubtree-update

…g#16634) Closes rust-lang/rust-clippy#11529 Closes rust-lang/rust-clippy#16631 Closes rust-lang/rust-clippy#15560 Closes rust-lang/rust-clippy#16344 This PR addresses two problems of `needless_range_loop`: 1. It suggests wrongly when the index is after other indexes or field accesses. 2. When the index is nested, it does not specify which index to replace, making the suggestion confusing. changelog: [`needless_range_loop`] fix wrong suggestions for nested index

*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust-clippy/pull/17499)* Adds `unnecessary_nonzero_get`, a `complexity` lint that drops `NonZero::get()` when the following method or operator is available on `NonZero` itself with the same return type. ```rust let _ = nz.get().leading_zeros(); // -> nz.leading_zeros() let _ = x / nz.get(); // -> x / nz ``` Methods only match when the `NonZero` version returns the same type. Cases like `bit_width` and `count_ones` return `NonZero`, so rewriting those would move the `get` instead of removing it, and they are skipped. Operators cover `/`, `%`, `/=` and `%=`. Three constraints keep the suggestion sound: - unsigned only, since `core` generates `Div`/`Rem` for `NonZero` from the unsigned arm only - not in const contexts, since the impls are `#[rustc_const_unstable]` - exact operand types, since primitive operators forward references but the `NonZero` impls do not MSRV is read from the impl or method rather than hardcoded. fixes rust-lang/rust-clippy#17483 - [x] Followed [lint naming conventions][lint_naming] - [x] Added passing UI tests (including committed `.stderr` file) - [x] `cargo test` passes locally - [x] Executed `cargo dev update_lints` - [x] Added lint documentation - [x] Run `cargo dev fmt` [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints changelog: new lint: [`unnecessary_nonzero_get`]

…tion

When checking stdout/err, color codes will get in the way of the simple comparisons that are performed during tests. Anyone setting CARGO_TERM_COLOR=always will experience test failures as a result. This forcibly disables coloring.

Per [#t-infra > funding link on rust-lang/rust is broken @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/funding.20link.20on.20rust-lang.2Frust.20is.20broken/near/615432496), the current link is broken. changelog: none

…ust-lang#17530) fixes rust-lang/rust-clippy#17501 changelog: [`cast_possible_truncation`]: fix `try_from` suggestion expanding macros instead of showing the macro call

When checking stdout/err, color codes will get in the way of the simple comparisons that are performed during tests. Anyone setting CARGO_TERM_COLOR=always will experience test failures as a result. This forcibly disables coloring for those tests that rely on doing a direct comparison. changelog: none

rust-lang#17532) changelog: none

Closes rust-lang/rust-clippy#16798 changelog: none

Extend the lint to catch if c { return W(true); } W(false) and reduce it to `W(c)` (or `W(!c)`), where `W` is an optional tuple-like constructor (`Ok`/`Some`/user enum & tuple-struct ctors) shared by both the guard and the trailing expression, or absent. Constructors are pure, so folding the condition into them preserves behavior. The values must differ (equal values are skipped, since the condition could have side effects), the guard body must be only the `return`, and the same constructor must wrap both bools. Also applies the new check to clippy's own source (dogfood).

*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust-clippy/pull/17185)* Extend the lint to catch if c { return W(true); } W(false) and reduce it to `W(c)` (or `W(!c)`), where `W` is an optional tuple-like constructor (`Ok`/`Some`/user enum & tuple-struct ctors) shared by both the guard and the trailing expression, or absent. Constructors are pure, so folding the condition into them preserves behavior. The values must differ (equal values are skipped, since the condition could have side effects), the guard body must be only the `return`, and the same constructor must wrap both bools. --- See example in the wild: uutils/coreutils#12689 changelog: needless_bool: lint the early-return guard form

…blocks Adding newline at end of file

This is in preparation for renaming the default branch to `main` (https://rust-lang.zulipchat.com/#narrow/channel/257328-t-clippy/topic/Renaming.20the.20Clippy.27s.20default.20branch.20to.20main/with/615804918). It should build the docs into both the `master` and `main` directories. After we confirm that this works, and that https://rust-lang.github.io/rust-clippy/main is available, we can modify Clippy to start generating links that will point to `main`, instead of `master`. changelog: none

rustbot · 2026-08-20T17:59:15Z

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Manishearth · 2026-08-20T18:13:38Z

@bors r+

rust-bors · 2026-08-20T18:13:41Z

📌 Commit 2b371e4 has been approved by Manishearth

It is now in the queue for this repository.

Manishearth · 2026-08-20T18:13:54Z

@birs p=1

Manishearth · 2026-08-20T18:14:06Z

@bors p=1

JonathanBrouwer · 2026-08-20T18:17:31Z

@bors r-
Failed PR ci

rust-bors · 2026-08-20T18:17:35Z

This pull request was unapproved.

View changes since this unapproval

*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust-clippy/pull/17537)* changelog: [`unnecessary_map_or`]: suggest `Result::is_ok` and `Result::is_err` for boolean `map_or` and `map_or_else` branches Fixes rust-lang/rust-clippy#5718 ## Summary - recognize `Result::map_or` and `Result::map_or_else` calls whose branches return opposite boolean literals without using their arguments - suggest `is_ok()` when the `Ok` branch is `true`, and `is_err()` when the `Err` branch is `true` - keep rustfix machine-applicable when drop order is insignificant, while downgrading the suggestion and explaining the difference when the result or its temporaries need ordered drop - extend the lint documentation and cover single-line, multiline, rustfix, negative, and significant-drop cases ## Validation - `TESTNAME=unnecessary_map_or cargo uitest` - `cargo dev fmt --check` - `cargo test`

rustbot · 2026-08-21T08:17:02Z

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

flip1995 · 2026-08-21T08:19:56Z

While fixing the Clippy finding, I thought a bit about what the condition in llvm.rs actually is trying to express. This was quite confusing with the double/triple negation going on there. So this requires bootstrap review. Or at least another person double checking my reasoning.

Consider updating src/bootstrap/download-ci-llvm-stamp.

I don't think this is necessary, as there was no behavioral change?

…ubtree-update

Also simplifies the LLVM toolchain CI lookup condition

rustbot · 2026-08-21T09:31:38Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rust-log-analyzer · 2026-08-21T09:52:52Z

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    Checking tracing-subscriber v0.3.23
error: this `if` guard returns a bool literal and is followed by another
   --> compiler/rustc_target/src/callconv/mod.rs:201:9
    |
201 | /         if self.arg_ext != other.arg_ext {
202 | |             return false;
203 | |         }
204 | |         true
    | |____________^ help: you can reduce it to: `self.arg_ext == other.arg_ext`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/main/index.html#needless_bool
    = note: requested on the command line with `-D clippy::needless-bool`

[RUSTC-TIMING] nix test:false 1.397

Gri-ffin and others added 30 commits July 10, 2026 20:08

fix duplicate diagnostics for msrv attrs

ba2989f

fix: needless_range_loop suggests wrongly for nested index

e5af49b

replace box_patterns usage with deref_patterns

02fe0f2

support deref patterns in unnested_or_patterns

284850a

ci: upgrade cache action from v4 to v5

96522c7

ci: upgrade upload-artifact action from v4 to v7

1aed118

remove one weird version of let-else

a98a712

mixed_read_write_in_expression: fix broken link to reference

af7cef9

feat: add unnecessary_nonzero_get lint

f0b8245

Merge commit '49e2f89a2605a9a340e04955fdbefa9803e6027a' into clippy-s…

3fba180

…ubtree-update

needless_range_loop: put .enumerate() into backticks

e62982b

Fix up lang_items import paths

76e7e12

Fix cast_possible_truncation suggested fix replaces macro with defini…

f9b8ed6

…tion

RELICENSE_DOCUMENTATION.md: add closing parenthesis, remove empty line

a415293

fix: set CARGO_TERM_COLOR=never in tests

f7816ac

When checking stdout/err, color codes will get in the way of the simple comparisons that are performed during tests. Anyone setting CARGO_TERM_COLOR=always will experience test failures as a result. This forcibly disables coloring.

Fix funding link

b982647

Fix funding link (rust-lang#17534)

3a9ae38

Per [#t-infra > funding link on rust-lang/rust is broken @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/funding.20link.20on.20rust-lang.2Frust.20is.20broken/near/615432496), the current link is broken. changelog: none

[cast_possible_truncation]: fix try_from suggestion expanding macros (r…

3317688

…ust-lang#17530) fixes rust-lang/rust-clippy#17501 changelog: [`cast_possible_truncation`]: fix `try_from` suggestion expanding macros instead of showing the macro call

RELICENSE_DOCUMENTATION.md: add closing parenthesis, remove empty line (

330f7a7

rust-lang#17532) changelog: none

rename HostEffectPredicate to HostEffectClause

673a9d8

ci: Bump Node.js 20 GitHub Actions (rust-lang#17493)

dded2db

Closes rust-lang/rust-clippy#16798 changelog: none

Build docs into the main directory

15e99c9

Don't lint semicolon_if_nothing_returned in #[automatically_derived] …

8fb0b61

…blocks Adding newline at end of file

rustbot added the T-clippy Relevant to the Clippy team. label Aug 20, 2026

flip1995 marked this pull request as ready for review August 20, 2026 17:59

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 20, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 20, 2026

This comment has been minimized.

Sign in to view

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 21, 2026

flip1995 added 3 commits August 21, 2026 11:30

Merge commit 'e8bea0328512886cca6e0c28e28f3e172689b484' into clippy-s…

df0c60b

…ubtree-update

Update Cargo.lock

2662c0c

Fix Clippy findings in bootstrap

4031602

Also simplifies the LLVM toolchain CI lookup condition

flip1995 force-pushed the clippy-subtree-update branch from afb660d to 4031602 Compare August 21, 2026 09:31

This comment was marked as resolved.

Sign in to view

flip1995 marked this pull request as draft August 21, 2026 14:28

Uh oh!

Uh oh!

Conversation

flip1995 commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 20, 2026

Uh oh!

This comment has been minimized.

Manishearth commented Aug 20, 2026

Uh oh!

rust-bors Bot commented Aug 20, 2026

Uh oh!

Manishearth commented Aug 20, 2026

Uh oh!

Manishearth commented Aug 20, 2026

Uh oh!

JonathanBrouwer commented Aug 20, 2026

Uh oh!

rust-bors Bot commented Aug 20, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Aug 21, 2026

Uh oh!

flip1995 commented Aug 21, 2026

Uh oh!

rustbot commented Aug 21, 2026

Uh oh!

This comment was marked as resolved.

rust-log-analyzer commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

flip1995 commented Aug 20, 2026 •

edited

Loading