move some attribute related structs out of rustc_attr_ir by mejrs · Pull Request #161259 · rust-lang/rust

mejrs · 2026-08-17T19:40:10Z

This changes it so that

rustc_session no longer depends on rustc_attr_ir
rustc_attr_ir no longer depends on rustc_target (which is a fairly sizeable crate)
rustc_attr_ir and rustc_target can compile in parallel

Previous graph:

Graph with this PR:

r? @JonathanBrouwer

rustbot · 2026-08-17T19:40:13Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

rustc_error_messages was changed

cc @TaKO8Ki

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

rustbot · 2026-08-17T19:59:17Z

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

rustbot · 2026-08-21T08:42:07Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer · 2026-08-21T08:42:35Z

^ Rebased, rustc_session is now also unused in clippy_lints

JonathanBrouwer · 2026-08-21T08:43:10Z

@@ -0,0 +1,15 @@
+//! Basic structs that end up being used in attributes for one reason or another,


This change is great, the only thing I'm iffy about is the name rustc_structures. The name is accurate because it's basically a lot of structs that don't have anything in common stuffed into a crate, but I'm also not sure how to feel about this concept.

I can't think of a better name and I don't want to start a bikeshedding session, so let's merge this if it improves bootstrap times, I'll do some measurements locally

View changes since the review

JonathanBrouwer · 2026-08-21T08:50:04Z

On my pc running rm -r build/x86_64-unknown-linux-gnu/stage1-rustc; ./x check compiler/rustc_middle, average of 5 measurements:

before this 14.1s
after this 13.4s

JonathanBrouwer · 2026-08-21T08:52:19Z

@bors r+ p=1 note=bitrotty

rust-bors · 2026-08-21T08:52:22Z

📌 Commit cf98f58 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…rouwer move some attribute related structs out of rustc_attr_ir This changes it so that - rustc_session no longer depends on rustc_attr_ir - rustc_attr_ir no longer depends on rustc_target (which is a fairly sizeable crate) - rustc_attr_ir and rustc_target can compile in parallel Previous graph: <img width="985" height="512" alt="image" src="https://github.com/user-attachments/assets/cbde2414-043e-45f2-88a2-f77a5c9df60c" /> Graph with this PR: <img width="1248" height="474" alt="image" src="https://github.com/user-attachments/assets/e0e13794-b17b-4337-8768-f0191cb1c0e6" /> r? @JonathanBrouwer

@JonathanBrouwer

…rouwer move some attribute related structs out of rustc_attr_ir This changes it so that - rustc_session no longer depends on rustc_attr_ir - rustc_attr_ir no longer depends on rustc_target (which is a fairly sizeable crate) - rustc_attr_ir and rustc_target can compile in parallel Previous graph: <img width="985" height="512" alt="image" src="https://github.com/user-attachments/assets/cbde2414-043e-45f2-88a2-f77a5c9df60c" /> Graph with this PR: <img width="1248" height="474" alt="image" src="https://github.com/user-attachments/assets/e0e13794-b17b-4337-8768-f0191cb1c0e6" /> r? @JonathanBrouwer

@JonathanBrouwer

…rouwer move some attribute related structs out of rustc_attr_ir This changes it so that - rustc_session no longer depends on rustc_attr_ir - rustc_attr_ir no longer depends on rustc_target (which is a fairly sizeable crate) - rustc_attr_ir and rustc_target can compile in parallel Previous graph: <img width="985" height="512" alt="image" src="https://github.com/user-attachments/assets/cbde2414-043e-45f2-88a2-f77a5c9df60c" /> Graph with this PR: <img width="1248" height="474" alt="image" src="https://github.com/user-attachments/assets/e0e13794-b17b-4337-8768-f0191cb1c0e6" /> r? @JonathanBrouwer

…uwer Rollup of 16 pull requests Successful merges: - #161259 (move some attribute related structs out of rustc_attr_ir) - #160853 (delegation: simplify matches on `FnKind`, minor refactorings) - #159899 ( `GenericArgs::types` triage + possible fixes) - #160459 (Use attribute parser for `deprecated` attribute checking) - #160813 (Optimize linked list iterator performance) - #161271 (doc: document safety requirements for core WTF-8) - #161317 (LLVM 24: configure float-abi via module flag) - #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow) - #161369 (Add regression test for confusing lifetime error message issue) - #161393 (Configure LLM policy URL for triagebot) - #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB) - #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test) - #161410 (Fix rustdoc remapping `documentation` scope documentation) - #161415 (Update expect messages in path docs to better follow guidelines) - #161438 (Change triagebot backport to ping T-libs-fcp) - #161442 (Add regression test for dead code on type alias used in impl self type) Failed merges: - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)

@JonathanBrouwer

…rouwer move some attribute related structs out of rustc_attr_ir This changes it so that - rustc_session no longer depends on rustc_attr_ir - rustc_attr_ir no longer depends on rustc_target (which is a fairly sizeable crate) - rustc_attr_ir and rustc_target can compile in parallel Previous graph: <img width="985" height="512" alt="image" src="https://github.com/user-attachments/assets/cbde2414-043e-45f2-88a2-f77a5c9df60c" /> Graph with this PR: <img width="1248" height="474" alt="image" src="https://github.com/user-attachments/assets/e0e13794-b17b-4337-8768-f0191cb1c0e6" /> r? @JonathanBrouwer

Rollup of 20 pull requests Successful merges: - #161259 (move some attribute related structs out of rustc_attr_ir) - #160853 (delegation: simplify matches on `FnKind`, minor refactorings) - #161161 (proc_macro: add support for 16-bit targets) - #159899 ( `GenericArgs::types` triage + possible fixes) - #160459 (Use attribute parser for `deprecated` attribute checking) - #160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization) - #160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection) - #160595 (Clarify `str::split_at` docs) - #160813 (Optimize linked list iterator performance) - #161271 (doc: document safety requirements for core WTF-8) - #161317 (LLVM 24: configure float-abi via module flag) - #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow) - #161369 (Add regression test for confusing lifetime error message issue) - #161393 (Configure LLM policy URL for triagebot) - #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB) - #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test) - #161410 (Fix rustdoc remapping `documentation` scope documentation) - #161415 (Update expect messages in path docs to better follow guidelines) - #161438 (Change triagebot backport to ping T-libs-fcp) - #161442 (Add regression test for dead code on type alias used in impl self type) Failed merges: - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)

rustbot assigned JonathanBrouwer Aug 17, 2026

This comment has been minimized.

Sign in to view

mejrs added 13 commits August 21, 2026 10:33

Move Limit

589bb91

move SanitizerSet

2a20dfa

make nightly feature

29dba3e

invert dependency on rustc_error_messages

f713bb2

move CrateType

38af4a2

Move NativeLibKind

8d970ff

move CollapseMacroDebuginfo

7bec351

Add crate docs

587412a

bless bootstrap

601e9d6

Fix tools

12278ac

fix miri

9e9c3b1

fix miri

c03400e

fix tests

20321fa

fix fulldeps

cf98f58

JonathanBrouwer force-pushed the attr_structures branch from 4305e6c to cf98f58 Compare August 21, 2026 08:42

JonathanBrouwer reviewed Aug 21, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2026

JonathanBrouwer changed the title ~~move some attribute related structs out ot rustc_attr_ir~~ move some attribute related structs out of rustc_attr_ir Aug 21, 2026

JonathanBrouwer mentioned this pull request Aug 21, 2026

Rollup of 11 pull requests #161445

Closed

JonathanBrouwer mentioned this pull request Aug 21, 2026

Rollup of 17 pull requests #161453

Closed

JonathanBrouwer mentioned this pull request Aug 21, 2026

Rollup of 16 pull requests #161455

Closed

jhpratt mentioned this pull request Aug 21, 2026

Rollup of 20 pull requests #161458

Open

Navigation Menu

Uh oh!

Uh oh!

move some attribute related structs out of rustc_attr_ir - #161259

move some attribute related structs out of rustc_attr_ir#161259
mejrs wants to merge 14 commits into
rust-lang:mainfrom
mejrs:attr_structures

mejrs commented Aug 17, 2026

Uh oh!

rustbot commented Aug 17, 2026

Uh oh!

This comment has been minimized.

rustbot commented Aug 17, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Aug 21, 2026

Uh oh!

JonathanBrouwer commented Aug 21, 2026 •

edited

Loading

Uh oh!

JonathanBrouwer Aug 21, 2026 •

edited by rustbot

Loading

Uh oh!

JonathanBrouwer commented Aug 21, 2026

Uh oh!

JonathanBrouwer commented Aug 21, 2026

Uh oh!

rust-bors Bot commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -0,0 +1,15 @@
		//! Basic structs that end up being used in attributes for one reason or another,

Uh oh!

Uh oh!

Conversation

mejrs commented Aug 17, 2026

Uh oh!

rustbot commented Aug 17, 2026

Uh oh!

This comment has been minimized.

rustbot commented Aug 17, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Aug 21, 2026

Uh oh!

JonathanBrouwer commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer Aug 21, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer commented Aug 21, 2026

Uh oh!

JonathanBrouwer commented Aug 21, 2026

Uh oh!

rust-bors Bot commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JonathanBrouwer commented Aug 21, 2026 •

edited

Loading

JonathanBrouwer Aug 21, 2026 •

edited by rustbot

Loading