Repository navigation
fix(bigchat): 신청·취소 반응 순서 보존과 리마인더 수신자 전환 - #176
Open
progresshans wants to merge 3 commits into
Open
progresshans wants to merge 3 commits into
progresshans wants to merge 3 commits into
Conversation
- Map batchGetByDataFilter results back by metadata ID instead of requiring the echoed filter to equal the request. The server already matched each filter on its full revision value, so a concurrent cancellation still cannot become a reminder recipient, while a normalized echo no longer aborts the day's reminders. - Check reminder recipients in the live Sheets verification run, since the in-memory double cannot show how the real API echoes filters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Catch failures per bigchat: log the cause, record the bigchat in ReminderResult.failed_bigchat_names and continue with the others. Failing to list the worksheets still fails the whole run. - The scheduled job tells the admin channel which bigchats were skipped, and the manual reminder command lists them in its report. - Append report notes after strip_multiline, so the report body is no longer sent indented when a note is present. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
#173만으로는 신청과 취소 이벤트가 뒤바뀌어 처리되면, 지연된 신청이 더 최신인 취소를 뒤집을 수 있습니다. 시트 생성 직후의 자동 등록도 그사이의 실시간 취소를 덮어쓸 수 있습니다. 리마인더는 여전히 시트의 이메일을 회원 명부와 맞춰 보내므로, 이메일이 바뀌거나 취소된 행에 메모가 남으면 수신자가 틀어집니다.
변경
event_ts와 신청·취소 상태를 저장합니다. 상태 변경과 A:D 쓰기는 읽었던 metadata 버전을 필터로 사용해, 그사이 더 최신 이벤트가 반영됐으면 쓰지 않습니다.reminder명령 보고에 표시합니다.검증
make ci통과: 앱 테스트 585개, 포맷·린트·타입 검사.test_reaction_ordering.py).