Repository navigation
fix(sheets): Tenacity 공통 재시도와 90초 작업 예산 적용 - #174
Open
progresshans wants to merge 9 commits into
Open
progresshans wants to merge 9 commits into
progresshans wants to merge 9 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 4, 2026
progresshans
force-pushed
the
fix/bigchat-bounded-read-retries
branch
from
November 5, 2026 02:34
761a9d6 to
e582c2e
Compare
progresshans
force-pushed
the
fix/bigchat-bounded-read-retries
branch
from
November 5, 2026 03:47
e582c2e to
c070dbf
Compare
progresshans
force-pushed
the
fix/bigchat-bounded-read-retries
branch
2 times, most recently
from
November 5, 2026 06:06
7ec71e2 to
cf0bba0
Compare
progresshans
force-pushed
the
fix/bigchat-bounded-read-retries
branch
2 times, most recently
from
November 5, 2026 07:08
34e1354 to
7ad3817
Compare
- Retry 429 reads after 5, 10, 20 and 30 seconds so the per-minute quota can refill; other transient errors keep the 1 and 2 second waits. - Stop retrying once an operation would pass 90 seconds. Writes hold the process lock, so this also bounds how long other registrations wait. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Check the operation budget only before new work starts: attempts, waits, lock acquisition and each send. A write that already committed, or a response that already arrived, is no longer discarded and reported as unconfirmed near the 90 second limit. - A late credential reply is kept, but the Sheets request after it is still refused before it reaches the network. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
progresshans
force-pushed
the
fix/bigchat-bounded-read-retries
branch
from
November 5, 2026 07:24
7ad3817 to
32cb338
Compare
This was referenced Nov 5, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32cb3385b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
progresshans
changed the base branch from
fix/bigchat-identity-and-sheet-errors
to
fix/bigchat-reaction-order-reminders
November 5, 2026 07:32
- Treat ChunkedEncodingError as transient. Requests derives it only from RequestException, so the shared policy rejected it as permanent, while the previous read decorator and store write policy retried it. - Writes still replay only after the confirmation read shows they were not applied. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
저장소의 재시도·결과 확인 로직이 여러 곳에 흩어져 있었고, 기존 Sheets 클라이언트는
with_retry로 모든 예외를 3초 간격으로 10번 재시도했습니다. 시도 횟수만 제한하면 잠금 대기와 여러 요청·재시도 시간이 합쳐져 신청·취소가 오래 기다릴 수 있습니다. 리뷰에서 제안된 Tenacity 도입과 재시도 조건의 데코레이터 분리를 이 PR에서 적용합니다.공통 재시도 정책
integrations/sheets_retry.py에 모았습니다.BigchatStore._read와 기존 값·제목·탭 목록 조회에@retry_reads를 적용합니다.shared.utils.with_retry와 내부 helper의 중첩 재시도를 제거했습니다. 일시 오류는 1·2초 간격, 429는 5·10·20·30초 간격으로 재시도하며, 영구 오류와 프로그래밍 오류는 즉시 전파합니다.guarded_write에서 결과 확인을 먼저 수행합니다. 확인 조회의 실패가 원래 쓰기의 재시도로 처리되지 않도록 Tenacity 시도 컨텍스트 밖에서 확인합니다. 고유 ID·버전 필터는 유지합니다.90초 작업 예산
BigchatStore공개 작업과 기존 Sheets 클라이언트의 공개 읽기마다 90초 마감 시각을 시작합니다. 중첩 호출은 같은 마감 시각을 사용합니다.제한의 의미
90초는 저장소 작업 하나의 예산이며 Slack 처리나 전체 일괄 등록의 총 소요 시간 제한은 아닙니다. 회원 조회의 Sheets 읽기도 같은 정책을 사용합니다.
HTTP timeout은 DNS 조회와 계속 수신되는 응답의 총 시간을 엄격하게 제한하지 않습니다. 이미 전송된 Google 요청도 강제로 취소할 수 없으므로 모든 상황에서 정확히 90초 이내 반환을 보장하지는 않습니다. 불확실한 쓰기를 백그라운드에 남긴 채 잠금을 풀거나 결과 확인 없이 다시 보내지는 않습니다.
검증
make ci통과: 앱 테스트 668개, 포맷·린트·타입 검사.