Repository navigation
refactor(bigchat): 생성·신청·취소의 Sheets 접근을 BigchatStore로 일원화 - #172
Open
progresshans wants to merge 1 commit into
Open
progresshans wants to merge 1 commit into
progresshans wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 4, 2026
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
왜 바꾸나요
빅챗 핸들러들이
GoogleSpreadsheetClient를 각자 직접 다뤄서, 저장 방식을 바꾸려면 핸들러를 모두 고쳐야 했습니다. #173에서 저장 방식을 바꾸기 전에 접근 경로를 한곳으로 모읍니다.변경
BigchatStore하나로 모았습니다. 멘션·모달 생성, 이모지 신청·취소, 시트를 만들기 전에 누른 이모지의 일괄 등록이 모두 이 저장소를 거칩니다.SpreadsheetBigchatRepository는BigchatStore로 대체했습니다.동작 변화
없습니다. 탭 생성 위치(index 3), 신청 순서, 기존 시트 처리, 스레드 답글의 시트 링크로 대상을 찾는 방식, gspread 예외를 그대로 올리는 동작은 이 PR에서 그대로 두고 #173에서 바꿉니다.
검증
make ci통과 (포맷·린트·타입 검사, 테스트)BigchatStore를 그대로 써서, 기존과 같은 Sheets 호출과 안내 메시지를 확인합니다.