TS2Swift: Skip type checks when translating TS -> Swift#567
TS2Swift: Skip type checks when translating TS -> Swift#567kateinoigakukun merged 1 commit intomainfrom
Conversation
| return ts.createProgram(roots, options, host); | ||
| return ts.createProgram(roots, { | ||
| ...options, | ||
| noCheck: true, |
There was a problem hiding this comment.
Would you mind adding a test that verifies this worked? The test case still hangs and produces an error for me, even though it's redeployed https://swiftwasm.org/JavaScriptKit/PlayBridgeJS/?code=H4sIAAAAAAAAE6tWKi7PTCtRslLS11fwL0jNU0hIKspMSU%2FVzSrWS9ErKU5QKElMUtJRSikpBipKrSjILypRSCvNSy7JzM9TSE8tcU7MK0ss1qiwUiguKcrMS9e0UvAI8fWBCLvmpOam5pVYK9UCANyqcRdpAAAA&enc=gzip-b64
There was a problem hiding this comment.
Hmm, I locally verified CLI invocation works much faster but still not enough on Web?
There was a problem hiding this comment.
On the web it's not just hanging, but also displaying Error generating code: BridgeJSLinkError(message: "Void can\'t appear in parameters of imported JS functions"). I've also seen this in CLI previously. Definitely worth adding a test case for something like export function getCanvas(x: string): HTMLCanvasElement; used in that sample
2 participants
Close #512