Skip to content

TS2Swift: Skip type checks when translating TS -> Swift #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kateinoigakukun merged 1 commit into from
Feb 3, 2026
Merged

TS2Swift: Skip type checks when translating TS -> Swift #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Plugins/BridgeJS/Sources/TS2Swift/JavaScript/src/processor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ export class TypeProcessor {
static createProgram(filePaths, options) {
const host = ts.createCompilerHost(options);
const roots = Array.isArray(filePaths) ? filePaths : [filePaths];
return ts.createProgram(roots, options, host);
return ts.createProgram(roots, {
...options,
noCheck: true,
Copy link
Member

@MaxDesiatov MaxDesiatov Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a test that verifies this worked? The test case still hangs and produces an error for me, even though it's redeployed https://swiftwasm.org/JavaScriptKit/PlayBridgeJS/?code=H4sIAAAAAAAAE6tWKi7PTCtRslLS11fwL0jNU0hIKspMSU%2FVzSrWS9ErKU5QKElMUtJRSikpBipKrSjILypRSCvNSy7JzM9TSE8tcU7MK0ss1qiwUiguKcrMS9e0UvAI8fWBCLvmpOam5pVYK9UCANyqcRdpAAAA&enc=gzip-b64

Copy link
Member Author

@kateinoigakukun kateinoigakukun Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I locally verified CLI invocation works much faster but still not enough on Web?

Copy link
Member

@MaxDesiatov MaxDesiatov Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the web it's not just hanging, but also displaying Error generating code: BridgeJSLinkError(message: "Void can\'t appear in parameters of imported JS functions"). I've also seen this in CLI previously. Definitely worth adding a test case for something like export function getCanvas(x: string): HTMLCanvasElement; used in that sample

skipLibCheck: true,
}, host);
}

/**
Expand Down