feat: Add 3D mesh endpoint to `@typegpu/geometry` by reczkok · Pull Request #2997 · software-mansion/TypeGPU

reczkok · 2026-09-08T01:20:40Z

Adds meshes to @typegpu/geometry. Geometry is a vertex schema + vertexAt (and optionally indexAt), so primitives and transformations compose before anything needs a buffer

plane, box, sphere, cylinder, torus + custom parametric surfaces
transform, map, attach extra attributes and concat geometries
evaluate directly in shaders, bake into buffers or bake just the indices while keeping vertices procedural
baked meshes can be updated through compute and used as geometry inputs again
includes an animated primitives example with shadows

Interactive cloth example and docs will follow in separate PRs

github-actions · 2026-09-08T01:21:46Z

pkg.pr.new

packages
Ready to be installed by your favorite package manager ⬇️

https://pkg.pr.new/software-mansion/TypeGPU/tgpu-gen@15b07a3a9142ae67344287be753c993dc13213a7

https://pkg.pr.new/software-mansion/TypeGPU/typegpu@15b07a3a9142ae67344287be753c993dc13213a7

https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/cli@15b07a3a9142ae67344287be753c993dc13213a7

https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/color@15b07a3a9142ae67344287be753c993dc13213a7

https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/gl@15b07a3a9142ae67344287be753c993dc13213a7

https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/radiance-cascades@15b07a3a9142ae67344287be753c993dc13213a7

benchmark
view benchmark

commit
view commit

github-actions · 2026-09-08T01:23:22Z

Bundle size comparison (`import * as ...` in PR vs `import * as ...` in target):

🟢 Decreased	➖ Unchanged	🔴 Increased	❔ Unknown
0	355	0	0

No notable changes.

If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu.

github-actions · 2026-09-08T01:24:01Z

Resolution Time Benchmark

---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [1.09, 2.25, 5.02, 8.21, 8.48, 15.43, 28.33, 28.68]
  line [1.13, 2.32, 5.10, 7.46, 9.20, 14.15, 28.34, 27.96]
  line [1.13, 2.27, 5.05, 7.47, 8.66, 14.67, 26.74, 29.45]

---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [0.31, 0.53, 0.76, 0.94, 1.22, 1.33, 1.59, 1.75]
  line [0.37, 0.62, 0.79, 0.96, 1.23, 1.26, 1.53, 1.80]
  line [0.35, 0.54, 0.76, 0.95, 1.28, 1.33, 1.58, 1.78]

---
config:
  themeVariables:
    xyChart:
      plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
  title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
  x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
  y-axis "time (ms)"
  line [1.12, 2.79, 4.99, 8.30, 15.50, 30.17, 63.05, 127.86]
  line [1.02, 2.27, 4.61, 7.79, 14.70, 30.24, 64.26, 128.74]
  line [0.95, 2.40, 4.04, 7.89, 14.21, 30.42, 62.25, 121.86]

deluksic · 2026-09-08T08:17:37Z

Please take a look at my (almost finished) branch, if you would like to incorporate any of it, or steal techniques

https://github.com/deluksic/TypeGPU/tree/de/geometry-spheres (it is more than spheres)

Copilot

🟡 Changes recommended

Baked-index consistency and primitive boundaries during concatenation need correction before approval.

2 open issues

1 file not reviewed

pnpm-lock.yaml: Generated file

What changed in this PR

Adds a composable meshes API to @typegpu/geometry, supporting procedural 3D geometry, shader evaluation, and GPU buffer baking.

Changes:

Introduces primitives, parametric surfaces, and geometry transformations and composition.
Adds full and index-only baking, asynchronous preparation, and compute-driven vertex updates.
Adds tests and an animated mesh gallery with shadows.

File	Description
`pnpm-lock.yaml`	Records geometry testing dependencies.
`packages/typegpu-geometry/vitest.config.mts`	Configures shader-aware unit tests.
`packages/typegpu-geometry/tsconfig.test.json`	Enables test type checking.
`packages/typegpu-geometry/tests/updates.test.ts`	Tests baking updates, bindings, and dispatch.
`packages/typegpu-geometry/tests/mesh.test.ts`	Tests primitives and geometry composition.
`packages/typegpu-geometry/tests/fixtures.ts`	Adds shared geometry and shader fixtures.
`packages/typegpu-geometry/tests/bake.test.ts`	Tests baking, buffer ownership, and pipeline injection.
`packages/typegpu-geometry/src/mesh/primitives.ts`	Implements five primitives and surface evaluators.
`packages/typegpu-geometry/src/mesh/parametric.ts`	Implements grid sampling and estimated normals.
`packages/typegpu-geometry/src/mesh/math.ts`	Adds coordinate-frame helpers.
`packages/typegpu-geometry/src/mesh/index.ts`	Exports the mesh API.
`packages/typegpu-geometry/src/mesh/geometry.ts`	Defines geometry contracts and vertex layouts.
`packages/typegpu-geometry/src/mesh/fill.ts`	Implements compute-based buffer filling.
`packages/typegpu-geometry/src/mesh/combinators.ts`	Implements transforms, mapping, attachment, and concatenation.
`packages/typegpu-geometry/src/mesh/bake.ts`	Implements baking and baked-mesh operations.
`packages/typegpu-geometry/src/index.ts`	Exposes the `meshes` namespace.
`packages/typegpu-geometry/package.json`	Adds test scripts and dependencies.
`apps/typegpu-docs/tests/individual-example-tests/mesh-primitives.test.ts`	Tests example shader resolution.
`apps/typegpu-docs/src/examples/rendering/mesh-primitives/spring.ts`	Defines an animated procedural spring.
`apps/typegpu-docs/src/examples/rendering/mesh-primitives/shading.ts`	Implements lighting and shadow sampling.
`apps/typegpu-docs/src/examples/rendering/mesh-primitives/meta.json`	Registers the example metadata.
`apps/typegpu-docs/src/examples/rendering/mesh-primitives/index.ts`	Sets up rendering, animation, and cleanup.
`apps/typegpu-docs/src/examples/rendering/mesh-primitives/index.html`	Provides the example canvas.
`apps/typegpu-docs/src/examples/rendering/mesh-primitives/geometry.ts`	Adds placement and color helpers.
`apps/typegpu-docs/src/examples/rendering/mesh-primitives/gallery.ts`	Arranges the primitive gallery.
`apps/typegpu-docs/src/examples/rendering/mesh-primitives/blob.ts`	Defines an animated parametric blob.

_{Review effort: Balanced}

pullfrog

ℹ️ No critical issues — two consistency/robustness points inline.

Reviewed changes

Reviewed the full meshes namespace in @typegpu/geometry and the new mesh-primitives example at 043c0ab.

meshes geometry model — Geometry/IndexedGeometry (schema + vertexAt/indexAt), Surface default schema, isIndexed, WeakMap-cached vertex layouts.
Primitives & parametric — plane/box/sphere/cylinder/torus, the surfaces helpers, and grid sampling with finite-difference normals.
Combinators — transform (inverse-transpose normal matrix + winding reversal on reflection), map, attach, unindexed, concat.
Baking — bake/bakeAsync and bakeIndices/bakeIndicesAsync, compute-driven fills, buffer ownership and destroy semantics.
Example & tests — animated shadowed gallery example; CPU geometry/winding tests, bake and update tests, and the example WGSL snapshot.

Verification: packages/typegpu-geometry tests (26 passed), the mesh-primitives example snapshot (1 passed), test:types, oxfmt --check, and oxlint --max-warnings=0 all pass locally.

^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏}

pullfrog

ℹ️ No new issues in the latest commits — one earlier thread (the concat boundary) still stands; the rest of this delta is clean.

Reviewed changes

Reviewed the 7 commits pushed since the prior pullfrog review at 043c0ab (350d0ca6..0b0b53a).

Build migrated to tsdown — replaced unbuild with a tsdown.config.ts and updated package.json exports/dependencies to match the sibling packages.
bevel join added — new lines/joins/bevel.ts, registered in joins, and miterJoinLimitSlot is now exported.
Normal matrix hardened — transform now uses a sign-corrected cofactor matrix instead of the inverse transpose, so flattening transforms keep valid normals and collapsed normals stay zero.
Fill recording unified — fill.ts gained recordFills, so bake/updateVertices record vertex and index fills into a single compute pass and honour a caller-supplied encoder/pass without submitting.
Buffer offsets added — bake/bakeIndices accept baseVertex/firstIndex to pack several meshes into shared buffers; the baked indexAt now reads the baked index buffer (resolves the earlier stale-indexAt thread).
sphere options renamed — segments/rings → radialSegments/heightSegments, matching cylinder; callers and tests updated.
Tests — new lines.test.ts, offset-baking cases in bake.test.ts, and a flattening-normals case in mesh.test.ts.

Verification at 0b0b53a: @typegpu/geometry tests (31 passed), the mesh-primitives example snapshot (1 passed), test:types, and the tsdown build all pass.

^{｜ Fix it ➔ ｜ View workflow run ｜ Using deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏}

pullfrog

ℹ️ No new issues in the re-reviewed commits — the earlier concat boundary thread remains open, so this is not an approval.

Reviewed changes

Re-reviewed the 7 commits pushed after 043c0ab0 (through 0b0b53a1) that make up this synchronize event's delta.

Build migrated to tsdown — unbuild and build.config.ts were replaced by a tsdown.config.ts using unplugin-typegpu/rolldown and unbundle: true, matching @typegpu/sdf and @typegpu/sort, with the dependent package.json exports/main and the lockfile updated.
bevel join added — lines/joins/bevel.ts was added and registered in joins, and miterJoinLimitSlot is now re-exported.
Normal matrix hardened — transform now uses a sign-corrected cofactor matrix, so flattening transforms keep valid normals and reflected normals stay outward.
Fill recording unified — fill.ts gained RecordOptions and recordFills, so bake and updateVertices record vertex and index fills into a single compute pass and honour a caller-supplied encoder or pass without submitting.
Buffer offsets added — bake/bakeIndices accept baseVertex/firstIndex, and the baked indexAt reads the baked index buffer.
sphere options renamed — segments/rings were renamed to radialSegments/heightSegments, matching cylinder.
Tests — added lines.test.ts, plus offset-baking and flattening-normals cases.

^{｜ Fix it ➔ ｜ View workflow run ｜ Using deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏}

pullfrog

ℹ️ No new issues in the commits reviewed since the last pullfrog review — the earlier concat boundary thread remains open, so this is not an approval.

Reviewed changes

Re-reviewed the 7 commits pushed after 043c0ab (through 0b0b53a1): the tsdown build migration, the bevel join, the hardened normal matrix, unified fill recording, buffer-offset baking, and the sphere option rename.

Build migrated to tsdown — build.config.ts was replaced by tsdown.config.ts (unplugin-typegpu/rolldown, unbundle: true, ESM), with the dependent package.json publish exports/main and dev dependencies updated to match @typegpu/sdf/@typegpu/sort.
bevel join added — lines/joins/bevel.ts cuts the outside of a turn with a straight edge, and miterJoinLimitSlot is now re-exported from the joins barrel.
Normal matrix hardened — transform now builds a sign-corrected cofactor matrix instead of the inverse transpose, so transforms that flatten or reflect a shape keep valid outward normals rather than collapsing or flipping them.
Fill recording unified — fill.ts gained RecordOptions/recordFills, so bake and updateVertices record vertex and index fills into a single compute pass and honour a caller-supplied encoder or pass without submitting.
Buffer offsets added — bake/bakeIndices accept baseVertex/firstIndex so several meshes can pack into shared buffers, and the baked indexAt now reads the baked index buffer.
sphere options renamed — segments/rings became radialSegments/heightSegments, matching cylinder; callers and tests were updated.
Tests — added lines.test.ts (bevel geometry and slot configuration) plus offset-baking, single-pass recording, and flattening-normals cases.

^{｜ Fix it ➔ ｜ View workflow run ｜ Using deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏}

pullfrog

ℹ️ No new issues in the follow-up commit — the earlier concat boundary thread remains open, so this is not an approval.

Reviewed changes

Reviewed the single commit pushed after the prior pullfrog review (0b0b53a → 95e1ad5b).

Example helpers widened — paint/place in the mesh-primitives example now take d.InferInput<d.Vec3f> (arrays, tuples, or vectors) and normalise to d.vec3f internally, so callers pass plain arrays and gallery.ts no longer imports d.

^{｜ Fix it ➔ ｜ View workflow run ｜ Using deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏}

aleksanderkatan

Enormous PR!

I leave mostly nits and questions

pullfrog

✅ No new issues found.

Reviewed changes

Reviewed the delta since the prior pullfrog review at 95e1ad5b — the single "address review" commit 4330f17.

Mesh generics tightened — ConstructibleSchema (Extract<d.AnyWgslData, () => unknown>) moved into geometry.ts, exported, and applied in place of d.AnyWgslData across Geometry, IndexedGeometry, isIndexed, layoutOf, map, unindexed, concat, and the bake/bakeIndices family.
Primitives reuse surface helpers — cylinder's side and torus now call surfaces.cylinder/surfaces.torus; verified algebraically identical to the inline math they replace, including the surfaces.torus(u, v, 0, 1) unit normal. sphere now documents why it skips the pole triangles.
Brace convention restored — single-statement if/await bodies in fill.ts, bake.ts, primitives.ts, and combinators.ts now use block braces.
Tests added — bakeIndices analogues (procedural vertexAt, index-only injection, offset baking, encoder recording), an attach field-collision test, and a topology guard in windingAgreesWithNormals.

Verification at 4330f17: @typegpu/geometry tests (36 passed), the mesh-primitives example snapshot (1 passed), and pnpm --filter @typegpu/geometry test:types (both tsconfigs) all pass.

^{｜ View workflow run ｜ Using deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏}

aleksanderkatan

Great job!

reczkok mentioned this pull request Sep 8, 2026

docs: Add @typegpu/geometry docs with interactive previews #2998

Open

reczkok force-pushed the feat/geometry-meshes branch from 4af9244 to b452155 Compare September 8, 2026 04:10

reczkok force-pushed the feat/geometry-meshes branch from b452155 to 434811e Compare September 9, 2026 14:48

reczkok mentioned this pull request Sep 9, 2026

feat: Add triangular patches to @typegpu/geometry #3014

Open

reczkok removed this pull request from stack #2999 September 9, 2026 14:49

reczkok added this pull request to stack #3015 September 9, 2026 14:50

reczkok force-pushed the feat/geometry-meshes branch from 1e09d9b to 6246334 Compare October 6, 2026 15:11

reczkok force-pushed the feat/geometry-meshes branch 2 times, most recently from 58c4fcb to 043c0ab Compare October 22, 2026 11:58

reczkok marked this pull request as ready for review October 22, 2026 11:59

Copilot AI balanced review requested due to automatic review settings October 22, 2026 11:59

Copilot started reviewing on behalf of reczkok October 22, 2026 12:02

View session

Copilot AI reviewed Oct 22, 2026

View reviewed changes

Comment thread packages/typegpu-geometry/src/mesh/bake.ts Resolved

Comment thread packages/typegpu-geometry/src/mesh/combinators.ts Resolved

pullfrog Bot reviewed Oct 22, 2026

View reviewed changes

Comment thread packages/typegpu-geometry/src/mesh/bake.ts Resolved

Comment thread packages/typegpu-geometry/src/mesh/combinators.ts Resolved

pullfrog Bot reviewed Oct 22, 2026

View reviewed changes

reczkok requested review from aleksanderkatan, cieplypolar, iwoplaza and vende11s October 22, 2026 14:47

aleksanderkatan reviewed Oct 27, 2026

View reviewed changes

pullfrog Bot reviewed Oct 27, 2026

View reviewed changes

reczkok force-pushed the feat/geometry-meshes branch from 4330f17 to 95f344f Compare October 28, 2026 23:29

aleksanderkatan approved these changes Oct 29, 2026

View reviewed changes

reczkok force-pushed the feat/geometry-meshes branch 2 times, most recently from 6a11f0c to 1a4d69f Compare November 2, 2026 23:31

reczkok added 19 commits November 4, 2026 10:21

Add procedural meshes to @typegpu/geometry

7ec8ae3

Add mesh primitives example

a929816

add thumbnail

7e99c77

drop core export, defensive checks and error-path tests

705ffdb

shell float-only surface functions

74255df

drop custom bind group mock

0f47959

address review

5298173

port to new orbit camera

ce58c5e

Fix geometry lockfile

6ab6d8f

Build @typegpu/geometry with tsdown

ca32d31

Export miterJoinLimitSlot

9c8eb45

Add a bevel join

aca8f73

Keep normals of transforms that flatten a shape

2d29b22

Record mesh baking into one compute pass

209b181

Bake meshes into shared buffers at an offset

6d699e1

Name sphere segments like cylinder segments

595095d

wider better

f388733

address review

14afee8

use stable command encoder

15b07a3

reczkok force-pushed the feat/geometry-meshes branch from 1a4d69f to 15b07a3 Compare November 4, 2026 09:21

reczkok added this to the 0.13.0 milestone Nov 4, 2026

reczkok requested a review from aleksanderkatan November 4, 2026 10:28

Conversation

reczkok commented Sep 8, 2026

Uh oh!

github-actions Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle size comparison (import * as ... in PR vs import * as ... in target):

Uh oh!

github-actions Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolution Time Benchmark

Uh oh!

deluksic commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

pullfrog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pullfrog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

pullfrog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

pullfrog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

pullfrog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

aleksanderkatan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pullfrog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

aleksanderkatan left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Sep 8, 2026 •

edited

Loading

github-actions Bot commented Sep 8, 2026 •

edited

Loading

Bundle size comparison (`import * as ...` in PR vs `import * as ...` in target):

github-actions Bot commented Sep 8, 2026 •

edited

Loading

deluksic commented Sep 8, 2026 •

edited

Loading