Repository navigation
Conversation
e69e63f to
bdc9342
Compare
|
pkg.pr.new packages benchmark commit |
Bundle size comparison (
|
| 🟢 Decreased | ➖ Unchanged | 🔴 Increased | ❔ Unknown |
|---|---|---|---|
| 0 | 355 | 0 | 0 |
No notable changes.
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu.
Resolution Time Benchmark---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.61, 1.21, 2.34, 3.97, 4.50, 7.40, 14.20, 15.48]
line [0.57, 1.12, 2.33, 3.72, 3.65, 7.46, 14.25, 15.83]
line [0.56, 1.04, 2.19, 3.87, 3.65, 6.23, 13.49, 13.18]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.15, 0.30, 0.41, 0.50, 0.66, 0.68, 0.92, 0.95]
line [0.15, 0.28, 0.38, 0.44, 0.60, 0.65, 0.75, 0.87]
line [0.20, 0.30, 0.40, 0.50, 0.64, 0.59, 0.72, 0.81]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.59, 1.37, 2.60, 3.96, 7.11, 14.97, 33.13, 67.91]
line [0.61, 1.35, 2.23, 4.03, 7.74, 14.89, 32.09, 64.33]
line [0.47, 1.25, 1.97, 3.85, 7.19, 14.05, 31.54, 61.30]
|
bdc9342 to
931f6a3
Compare
931f6a3 to
24626f1
Compare
211795a to
86df052
Compare
86df052 to
9922b8c
Compare
9922b8c to
03f7d84
Compare
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This run reviewed the full @typegpu/geometry docs PR against its stacked base feat/geometry-patches, including the interactive preview runtime and its regression test.
- Docs guide (
typegpu-geometry.mdx) — 558-line guide covering primitives, parametric surfaces, triangular patches, custom geometry, combinators, baking/updating and lines/joins/caps; prose claims spot-checked againstpackages/typegpu-geometry/src. - Preview viewer (
viewer.ts,renderer.ts,shaders.ts,demos.ts) — shared-root WebGPU viewer with visibility/pause gating, per-schema pipeline caching, deferred resource cleanup and five demo scenes. - React shell (
MeshPreview.tsx) — param/shading/pause controls plus loading and error states. - Docs nav (
astro.config.mjs) —DEV-gated@typegpu/geometrysidebar entry with adevbadge. - Regression test (
mesh-preview.test.ts) — pins that a bake in flight at disposal submits before its uniforms are destroyed.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
There was a problem hiding this comment.
🟡 Changes recommended
The line-rendering example leaves its control points uninitialized, so it renders no visible line.
1 open issue
What changed in this PR
Adds an @typegpu/geometry guide with interactive mesh previews, extending the documentation to cover the triangular patches introduced in #3014.
Changes:
- Documents primitives, composition, custom attributes, mesh evaluation and updates, and line rendering.
- Adds configurable previews with smooth, flat, and wireframe shading.
- Adds a disposal regression test and development-only sidebar navigation.
| File | Description |
|---|---|
apps/typegpu-docs/tests/individual-example-tests/mesh-preview.test.ts |
Tests disposal while asynchronous baking is pending. |
apps/typegpu-docs/src/content/docs/ecosystem/typegpu-geometry.mdx |
Adds the geometry guide and embedded previews. |
apps/typegpu-docs/src/components/geometry/viewer.ts |
Manages preview state, animation, baking, and cleanup. |
apps/typegpu-docs/src/components/geometry/shaders.ts |
Defines lighting and shading modes. |
apps/typegpu-docs/src/components/geometry/renderer.ts |
Handles render pipelines, camera updates, and depth textures. |
apps/typegpu-docs/src/components/geometry/MeshPreview.tsx |
Adds preview controls and visibility handling. |
apps/typegpu-docs/src/components/geometry/demos.ts |
Defines configurable geometry demonstrations. |
apps/typegpu-docs/astro.config.mjs |
Adds the development-only geometry sidebar entry. |
Review effort: Balanced
03f7d84 to
9b0a57e
Compare
286afb9 to
ffef34c
Compare
032ea0a to
ffba348
Compare
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This run re-reviewed the delta since the prior pullfrog review: the branch was rebased onto the latest feat/geometry-patches tip and its preview code and guide snippets were migrated off the deprecated unstable command-encoder API.
- Stable encoder migration —
viewer.tsand the twotypegpu-geometry.mdxsnippets now call the stableroot.createCommandEncoder()instead ofroot['~unstable'].createCommandEncoder(). The unstable overload is deprecated in favour of the stable method, so the swap is equivalent, and no~unstableusages remain in the PR.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
ffba348 to
6a89b08
Compare


Adds a guide for
@typegpu/geometry, covering mesh creation, composition and the different ways to evaluate and update geometryStacks on #3014