Fix gossip bid rejection at epoch boundaries and on the head's parent - #10061
Merged
mergify[bot] merged 2 commits intoSep 23, 2026
Merged
Conversation
jimmygchen
added
bug
jimmygchen
marked this pull request as ready for review
September 17, 2026 06:10
jtraglia
added a commit
to ethereum/consensus-specs
that referenced
this pull request
Sep 21, 2026
…5645) Adds a gossip validation test for an execution payload bid that builds on the parent of the head beacon block. The head and parent states have different RANDAO mixes. The test checks that a bid with `prev_randao` from the state identified by `parent_block_root` is accepted, and fails if validation uses the head state's mix. Related Lighthouse fix: sigp/lighthouse#10061 Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
michaelsproul
approved these changes
Sep 23, 2026
michaelsproul
left a comment
michaelsproul
left a comment
Member
There was a problem hiding this comment.
Need this for the next spec (my LLM reimplemented it)
I'll merge this first
michaelsproul
added
ready-for-merge
Merge Queue Status
This pull request spent 29 minutes 56 seconds in the queue, including 28 minutes 29 seconds running CI. Required conditions to merge
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Valid payload bids can be dropped with
EpochOutOfBoundswhen the cached head is from the previous epoch. Bids on the head's parent can also be rejected withInvalidPrevRandaobecause validation uses the head's RANDAO mix.Proposed Changes
Validate
prev_randaoagainst the bid's beacon parent using the existinghead_randomandparent_randomhelpers. Add a regression for a head in the previous epoch. Head-parent RANDAO spec coverage is tracked in consensus-specs#5645.Additional Info
The Gloas gossip rule uses the parent post-state's current epoch. Related to #9924.