Test RANDAO checks for execution payload bids on the head's parent - #5645
Merged
jtraglia merged 3 commits intoSep 21, 2026
Merged
Conversation
jimmygchen
marked this pull request as ready for review
September 17, 2026 05:52
jimmygchen
changed the title
jimmygchen
changed the title
jtraglia
approved these changes
Sep 21, 2026
jtraglia
left a comment
jtraglia
left a comment
Member
There was a problem hiding this comment.
LGTM. I'm always a little worried that the test makes some change that are not represented in the test inputs. There are a few lines like blocks_meta[-2]["payload"] = get_filename(parent_payload) which look a bit sketchy but I'll trust that it's fine 😅 I'm going to merge this and cross my fingers that it's a proper test.
mergify Bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Sep 23, 2026
…#10061) ## Issue Addressed Valid payload bids can be dropped with `EpochOutOfBounds` when the cached head is from the previous epoch. Bids on the head's parent can also be rejected with `InvalidPrevRandao` because validation uses the head's RANDAO mix. ## Proposed Changes Validate `prev_randao` against the bid's beacon parent using the existing `head_random` and `parent_random` helpers. Add a regression for a head in the previous epoch. Head-parent RANDAO spec coverage is tracked in [consensus-specs#5645](ethereum/consensus-specs#5645). ## Additional Info The [Gloas gossip rule](https://github.com/ethereum/consensus-specs/blob/a8475719ce77cb269191e327e1f4175c295851ee/specs/gloas/p2p-interface.md#execution_payload_bid) uses the parent post-state's current epoch. Related to #9924.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a gossip validation test for an execution payload bid that builds on the parent of the head beacon block. The head and parent states have different RANDAO mixes. The test checks that a bid with
prev_randaofrom the state identified byparent_block_rootis accepted, and fails if validation uses the head state's mix.Related Lighthouse fix: sigp/lighthouse#10061