Clippy subtree update

Cargo.lock

@@ -658,7 +658,7 @@ checksum = "c8d4a3bb8b1e0c1050499d1815f5ab16d04f0959b233085fb31653fbfc9d98f9"
 
 [[package]]
 name = "clippy"
-version = "0.1.99"
+version = "0.1.100"
 dependencies = [
  "anstream 0.6.21",
  "askama",
@@ -683,7 +683,7 @@ dependencies = [
 
 [[package]]
 name = "clippy_config"
-version = "0.1.99"
+version = "0.1.100"
 dependencies = [
  "arrayvec",
  "clippy_utils",
@@ -707,7 +707,7 @@ dependencies = [
 
 [[package]]
 name = "clippy_lints"
-version = "0.1.99"
+version = "0.1.100"
 dependencies = [
  "arrayvec",
  "cargo_metadata 0.23.1",
@@ -738,7 +738,7 @@ dependencies = [
 
 [[package]]
 name = "clippy_utils"
-version = "0.1.99"
+version = "0.1.100"
 dependencies = [
  "arrayvec",
  "itertools",
@@ -1152,7 +1152,7 @@ checksum = "a0afaad2b26fa326569eb264b1363e8ae3357618c43982b3f285f0774ce76b69"
 
 [[package]]
 name = "declare_clippy_lint"
-version = "0.1.99"
+version = "0.1.100"
 
 [[package]]
 name = "derive-where"

compiler/rustc_hir_analysis/src/hir_ty_lowering/dyn_trait.rs

@@ -401,12 +401,12 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
 
                 // Like for trait refs, verify that `dummy_self` did not leak inside default type
                 // parameters.
-                let references_self = b.projection_term.args.iter().skip(1).any(|arg| {
-                    if arg.walk().any(|arg| arg == dummy_self.into()) {
-                        return true;
-                    }
-                    false
-                });
+                let references_self = b
+                    .projection_term
+                    .args
+                    .iter()
+                    .skip(1)
+                    .any(|arg| arg.walk().any(|arg| arg == dummy_self.into()));
                 if references_self {
                     let guar = tcx
                         .dcx()

compiler/rustc_mir_transform/src/inline.rs

@@ -343,11 +343,7 @@ impl<'tcx> Inliner<'tcx> for NormalInliner<'tcx> {
         // Avoid inlining into coroutines, since their `optimized_mir` is used for layout computation,
         // which can create a cycle, even when no attempt is made to inline the function in the other
         // direction.
-        if body.coroutine.is_some() {
-            return false;
-        }
-
-        true
+        body.coroutine.is_none()
     }
 
     #[instrument(level = "debug", skip(self, callee_body))]

compiler/rustc_trait_selection/src/traits/coherence.rs

@@ -698,12 +698,7 @@ fn try_prove_negated_where_clause<'tcx>(
     // FIXME: We could use the assumed_wf_types from both impls, I think,
     // if that wasn't implemented just for LocalDefId, and we'd need to do
     // the normalization ourselves since this is totally fallible...
-    let errors = ocx.resolve_regions(CRATE_DEF_ID, param_env, []);
-    if !errors.is_empty() {
-        return false;
-    }
-
-    true
+    ocx.resolve_regions(CRATE_DEF_ID, param_env, []).is_empty()
 }
 
 /// Compute the `intercrate_ambiguity_causes` for the new solver using

compiler/rustc_trait_selection/src/traits/mod.rs

@@ -859,12 +859,7 @@ pub fn impossible_clauses<'tcx>(tcx: TyCtxt<'tcx>, clauses: Vec<ty::Clause<'tcx>
     // vs user-written impls to AMBIGUOUS, this may return ambiguity even
     // with no infer vars. There may also be ways to encounter ambiguity due
     // to post-mono overflow.
-    let true_errors = ocx.try_evaluate_obligations();
-    if !true_errors.no_errors() {
-        return true;
-    }
-
-    false
+    !ocx.try_evaluate_obligations().no_errors()
 }
 
 fn instantiate_and_check_impossible_clauses<'tcx>(

src/bootstrap/src/core/build_steps/llvm.rs

@@ -356,13 +356,10 @@ pub(crate) fn is_ci_llvm_available_for_target(
         ("x86_64-unknown-netbsd", false),
     ];
 
-    if !supported_platforms.contains(&(&*host_target.triple, asserts))
-        && (asserts || !supported_platforms.contains(&(&*host_target.triple, true)))
-    {
-        return false;
-    }
-
-    true
+    // Check if the host target is available with the requested assertions (true/false),
+    supported_platforms.contains(&(&*host_target.triple, asserts))
+        // if it is not available for the given `asserts`, check if it is available with assertions (superset).
+        || supported_platforms.contains(&(&*host_target.triple, true))
 }
 
 #[derive(Clone)]

src/bootstrap/src/core/build_steps/setup.rs

@@ -375,11 +375,7 @@ fn ensure_stage1_toolchain_placeholder_exists(stage_path: &str) -> bool {
 
     // Take care not to overwrite the file
     let result = File::options().append(true).create(true).open(&pathbuf);
-    if result.is_err() {
-        return false;
-    }
-
-    true
+    result.is_ok()
 }
 
 // Used to get the path for `Subcommand::Setup`

src/tools/clippy/.github/FUNDING.yml

@@ -1,2 +1,2 @@
 github: rustfoundation
-custom: [ "rust-lang.org/funding" ]
+custom: [ "https://rust-lang.org/funding" ]

src/tools/clippy/.github/deploy.sh

@@ -4,6 +4,7 @@ set -ex
 
 echo "Removing the current docs for master"
 rm -rf out/master/ || exit 0
+rm -rf out/main/ || exit 0
 
 echo "Making the docs for master"
 mkdir out/master/
@@ -12,6 +13,9 @@ cp util/gh-pages/theme.js out/master
 cp util/gh-pages/script.js out/master
 cp util/gh-pages/style.css out/master
 
+echo "Copying the docs into the main directory"
+cp -Tr out/master/ out/main/
+
 if [[ -n $TAG_NAME ]]; then
   echo "Save the doc for the current tag ($TAG_NAME) and point stable/ to it"
   cp -Tr out/master "out/$TAG_NAME"