Update cargo submodule by weihanglo · Pull Request #161273 · rust-lang/rust

weihanglo · 2026-08-18T03:29:14Z

6 commits in 8a0d8afba810304bcf9a10bac430be80dd470233..514c56dd7321eecbfdcf9b6479519cf4edfab906
2026-08-15 01:32:53 +0000 to 2026-08-19 00:31:04 +0000

fix(git): git gc with safe.bareRepository=explicit (fix(git): git gc with safe.bareRepository=explicit cargo#17370)
test: make snapshots agnostic to -Zembed-metadata=no (test: make snapshots agnostic to -Zembed-metadata=no cargo#17374)
fix(clean): Improving description for clean options (fix(clean): Improving description for clean options cargo#17365)
Re-stabilize build-dir layout v2 (Re-stabilize build-dir layout v2 cargo#17354)
Enable -Zembed-metadata=no by default on nightly Cargo (Enable -Zembed-metadata=no by default on nightly Cargo cargo#17267)
fix(frontmatter): Don't panic on a short closing fence before a non-ASCII char (fix(frontmatter): Don't panic on a short closing fence before a non-ASCII char cargo#17274)

rustbot · 2026-08-18T03:29:18Z

⚠️ Warning ⚠️

Some commits in this PR modify submodules.

If this was not intentional, see I changed a submodule on accident in the rustc dev guide.

weihanglo · 2026-08-18T12:56:06Z

@bors r+ rollup=never p=1

rust-bors · 2026-08-18T12:56:09Z

📌 Commit 144981e has been approved by weihanglo

It is now in the queue for this repository.

Kobzol · 2026-08-18T13:44:12Z

@bors try jobs=dist-x86_64-linux @rust-timer queue

Update cargo submodule try-job: dist-x86_64-linux

rust-bors · 2026-08-18T15:16:01Z

☀️ Try build successful (CI)
Build commit: 2b31d55 (2b31d55819fbe2688d6819b19544d15c46e81b52)
Base parent: 444dcce (444dcce484c66c8d626806a8556be3b4d3ef381a)

rust-timer · 2026-08-18T15:59:00Z

Finished benchmarking commit (2b31d55): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.2%	[0.8%, 1.7%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.7%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.5%, secondary -8.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-8.4%	[-11.5%, -2.8%]	8
All ❌✅ (primary)	-1.5%	[-1.5%, -1.5%]	1

Cycles

Results (secondary -4.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.8%	[5.8%, 5.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-9.6%	[-9.9%, -9.3%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -58.4%, secondary -39.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-58.4%	[-100.0%, -0.0%]	142
Improvements ✅ (secondary)	-39.8%	[-100.0%, -0.1%]	197
All ❌✅ (primary)	-58.4%	[-100.0%, -0.0%]	142

Bootstrap: 455.347s -> 457.651s (0.51%)
Artifact size: 398.98 MiB -> 398.95 MiB (-0.01%)

Update cargo submodule 3 commits in 8a0d8afba810304bcf9a10bac430be80dd470233..36e1162a7989dd1d11b75bfa90283efcbf162cac 2026-08-15 01:32:53 +0000 to 2026-08-18 02:35:44 +0000 - Re-stabilize build-dir layout v2 (rust-lang/cargo#17354) - Enable `-Zembed-metadata=no` by default on nightly Cargo (rust-lang/cargo#17267) - fix(frontmatter): Don't panic on a short closing fence before a non-ASCII char (rust-lang/cargo#17274) r? ghost

Kobzol · 2026-08-18T16:44:32Z

Well, you don't see such (binary size) wins often.. :) I suppose that we should start tracking the .rmeta size too, because after this change, the .rlibs might be quite "empty" for some crates.

rust-bors · 2026-08-18T17:02:37Z

💔 Test for 4acb4d7 failed: CI. Failed job:

auto - x86_64-gnu-aux (web logs, enhanced plaintext logs)

Kobzol · 2026-08-18T18:49:51Z

Hmm, I guess we'll have to add a special env. var to opt out of opting into -Zembed-metadata=no in bootstrap when running Cargo's tests?

weihanglo · 2026-08-18T19:07:26Z

Hmm, I guess we'll have to add a special env. var to opt out of opting into -Zembed-metadata=no in bootstrap when running Cargo's tests?

We probably just need to be more lenient on those snapshots. I am back now and will fix it.

### What does this PR try to resolve? I've considered change https://github.com/rust-lang/cargo/blob/19112f96270d68fc834ce94bccf789c463078312/src/compiler/build_context/target_info.rs#L353-L356 to ```rust let cargo_nightly = matches!( crate::version().release_channel.as_deref(), Some("nightly" | "dev") | None ); ``` As non release channel means you are developing cargo. Considering it may affect libcargo users, I gave up. (I am biased as I am a libcargo consumer at work) Let me know which you think the best. ### How to test and review this PR? To reproduce this rust-lang/rust failure: <https://triage.rust-lang.org/gha-logs/rust-lang/rust/95781922166>, you can run ``` CFG_RELEASE_CHANNEL=nightly cargo +nightly test ``` See rust-lang/rust#161273 (comment) **LLM disclosure**: I told LLM to simulate Cargo CI and test against it, plus rust-lang/rust CI.

rustbot · 2026-08-19T01:17:27Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

weihanglo · 2026-08-19T01:17:59Z

@bors try jobs=x86_64-gnu-aux

Update cargo submodule try-job: x86_64-gnu-aux

weihanglo · 2026-08-19T03:02:25Z

@bors r+ rollup=never p=1

rust-bors · 2026-08-19T03:02:28Z

📌 Commit 352e9f1 has been approved by weihanglo

It is now in the queue for this repository.

rust-bors · 2026-08-19T03:49:39Z

☀️ Try build successful (CI)
Build commit: a764521 (a764521bb589aabdc83250c6e901b02ae8bb2ead)
Base parent: e71c0f1 (e71c0f1e3395b10a8c331317be1a5c107bdf7b2e)

rust-bors · 2026-08-19T08:56:21Z

☀️ Test successful - CI
Approved by: weihanglo
Duration: 3h 1m 50s
Pushing 407371f to main...

github-actions · 2026-08-19T08:59:43Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9ba81c2 (parent) -> 407371f (this PR)

Test differences

Show 10 test diffs

Stage 2

build_dir::build_script_should_output_to_build_dir: [missing] -> pass (J0)
rustdoc::rustdoc_json_with_new_layout: ignore (--output-format is unstable) -> [missing] (J0)
util::frontmatter::test::split_fewer_dashes: [missing] -> pass (J0)
util::frontmatter::test::split_fewer_dashes_before_non_ascii: [missing] -> pass (J0)
util::frontmatter::test::split_fewer_dashes_by_one: [missing] -> pass (J0)

Additionally, 5 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: aarch64-apple-2, aarch64-apple-macos-26-2, aarch64-gnu, x86_64-gnu-aux, x86_64-msvc-ext1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 407371fb751c935c0380baf9965beca6ae6174e7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-msvc-ext1: 1h 27m -> 2h 26m (+66.9%)
x86_64-gnu-stdlib-semver-check: 19m 55s -> 10m 35s (-46.9%)
i686-msvc-1: 3h 6m -> 1h 43m (-44.3%)
x86_64-msvc-2: 2h 35m -> 1h 28m (-43.3%)
x86_64-gnu-llvm-22-1: 54m 14s -> 1h 14m (+37.1%)
i686-gnu-1: 1h 31m -> 2h 5m (+36.4%)
dist-apple-various: 2h 56m -> 1h 57m (-33.6%)
x86_64-gnu-gcc-core-tests: 17m 58s -> 12m 13s (-32.0%)
dist-ohos-aarch64: 1h -> 1h 19m (+32.0%)
x86_64-gnu-llvm-22-3: 1h 51m -> 1h 16m (-31.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Kobzol · 2026-08-19T09:16:17Z

Ok, good, thank you! So starting from the 2026-08-20 nightly (or will it be named 2026-08-19? I always get this wrong), we should have -Zembed-metadata=no used by default.

rust-timer · 2026-08-19T09:45:29Z

Finished benchmarking commit (407371f): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.2%	[0.8%, 1.7%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.7%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.0%, secondary -8.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	[-1.0%, -1.0%]	1
Improvements ✅ (secondary)	-8.4%	[-11.4%, -2.9%]	8
All ❌✅ (primary)	-1.0%	[-1.0%, -1.0%]	1

Cycles

Results (secondary -4.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.2%	[-10.0%, -2.4%]	3
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -65.8%, secondary -66.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-65.8%	[-100.0%, -2.7%]	126
Improvements ✅ (secondary)	-66.4%	[-100.0%, -1.1%]	118
All ❌✅ (primary)	-65.8%	[-100.0%, -2.7%]	126

Bootstrap: 455.183s -> 458.213s (0.67%)
Artifact size: 398.99 MiB -> 399.03 MiB (0.01%)

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2026

weihanglo mentioned this pull request Aug 18, 2026

Add post about using -Zembed-metadata=no by default on nightly rust-lang/blog.rust-lang.org#1910

Merged

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 18, 2026

rust-bors Bot pushed a commit that referenced this pull request Aug 18, 2026

Auto merge of #161273 - weihanglo:update-cargo, r=<try>

2b31d55

Update cargo submodule try-job: dist-x86_64-linux

Kobzol mentioned this pull request Aug 18, 2026

Enable -Znext-solver on nightly by default #160619

Open

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 18, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 18, 2026

weihanglo mentioned this pull request Aug 18, 2026

test: make snapshots agnostic to -Zembed-metadata=no rust-lang/cargo#17374

Merged

Update cargo submodule

352e9f1

weihanglo force-pushed the update-cargo branch from 144981e to 352e9f1 Compare August 19, 2026 01:17

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 19, 2026

Auto merge of #161273 - weihanglo:update-cargo, r=<try>

a764521

Update cargo submodule try-job: x86_64-gnu-aux

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 19, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 19, 2026

rust-bors Bot merged commit 407371f into rust-lang:main Aug 19, 2026
15 checks passed

rustbot added this to the 1.100.0 milestone Aug 19, 2026

rust-bors Bot mentioned this pull request Aug 19, 2026

Add codeview_annotation intrinsic #160285

Draft

Kobzol mentioned this pull request Aug 19, 2026

Add crate metadata to compare page quick links rust-lang/rustc-perf#2539

Open

Uh oh!

Uh oh!

Conversation

weihanglo commented Aug 18, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 18, 2026

Uh oh!

weihanglo commented Aug 18, 2026

Uh oh!

rust-bors Bot commented Aug 18, 2026

Uh oh!

Kobzol commented Aug 18, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 18, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Aug 18, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Uh oh!

This comment has been minimized.

Kobzol commented Aug 18, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 18, 2026

Uh oh!

Kobzol commented Aug 18, 2026

Uh oh!

weihanglo commented Aug 18, 2026

Uh oh!

rustbot commented Aug 19, 2026

Uh oh!

weihanglo commented Aug 19, 2026

Uh oh!

This comment has been minimized.

weihanglo commented Aug 19, 2026

Uh oh!

rust-bors Bot commented Aug 19, 2026

Uh oh!

rust-bors Bot commented Aug 19, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 19, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026

Test differences

Stage 2

Job duration changes

Uh oh!

Kobzol commented Aug 19, 2026

Uh oh!

rust-timer commented Aug 19, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

weihanglo commented Aug 18, 2026 •

edited by rustbot

Loading