test: make snapshots agnostic to -Zembed-metadata=no - #17374
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
weihanglo
force-pushed
the
embed
branch
2 times, most recently
from
August 18, 2026 22:59
f9b1231 to
2c8e0a9
Compare
I've considered change https://github.com/rust-lang/cargo/blob/19112f96270d68fc834ce94bccf789c463078312/src/compiler/build_context/target_info.rs#L353-L356 to ```rust let cargo_nightly = matches!( crate::version().release_channel.as_deref(), Some("nightly" | "dev") | None ); ``` As non release channel means you are developing cargo. Considering it may affect libcargo users, I gave up. (I am biased as I am a libcargo consumer at work) Let me know which you think the best. To reproduce this rust-lang/rust failure: <https://triage.rust-lang.org/gha-logs/rust-lang/rust/95781922166>, you can run ``` CFG_RELEASE_CHANNEL=nightly cargo +nightly test ```
Member
Author
|
(Sigh) |
epage
approved these changes
Aug 18, 2026
epage
enabled auto-merge
August 18, 2026 23:06
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Aug 19, 2026
Update cargo submodule 6 commits in 8a0d8afba810304bcf9a10bac430be80dd470233..514c56dd7321eecbfdcf9b6479519cf4edfab906 2026-08-15 01:32:53 +0000 to 2026-08-19 00:31:04 +0000 - fix(git): `git gc` with `safe.bareRepository=explicit` (rust-lang/cargo#17370) - test: make snapshots agnostic to `-Zembed-metadata=no` (rust-lang/cargo#17374) - fix(clean): Improving description for clean options (rust-lang/cargo#17365) - Re-stabilize build-dir layout v2 (rust-lang/cargo#17354) - Enable `-Zembed-metadata=no` by default on nightly Cargo (rust-lang/cargo#17267) - fix(frontmatter): Don't panic on a short closing fence before a non-ASCII char (rust-lang/cargo#17274)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
I've considered change
cargo/src/compiler/build_context/target_info.rs
Lines 353 to 356 in 19112f9
to
As non release channel means you are developing cargo.
Considering it may affect libcargo users, I gave up.
(I am biased as I am a libcargo consumer at work)
Let me know which you think the best.
How to test and review this PR?
To reproduce this rust-lang/rust failure:
https://triage.rust-lang.org/gha-logs/rust-lang/rust/95781922166,
you can run
See rust-lang/rust#161273 (comment)
LLM disclosure: I told LLM to simulate Cargo CI and test against it, plus rust-lang/rust CI.