Skip to content

feat: add deployments route#4357

Merged
jog1t merged 13 commits intofeat/debug-inspector-infofrom
feat/deployments
Mar 13, 2026
Merged

feat: add deployments route#4357
jog1t merged 13 commits intofeat/debug-inspector-infofrom
feat/deployments

Conversation

@jog1t
Copy link
Contributor

@jog1t jog1t commented Mar 4, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jog1t
Copy link
Contributor Author

jog1t commented Mar 4, 2026

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4357 March 4, 2026 23:02 Destroyed
@railway-app
Copy link

railway-app bot commented Mar 4, 2026

🚅 Deployed to the rivet-pr-4357 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-cloud ✅ Success (View Logs) Web Mar 13, 2026 at 6:55 pm
website 😴 Sleeping (View Logs) Web Mar 13, 2026 at 6:54 pm
frontend-inspector ✅ Success (View Logs) Web Mar 13, 2026 at 6:53 pm
ladle ❌ Build Failed (View Logs) Web Mar 13, 2026 at 6:52 pm
mcp-hub ✅ Success (View Logs) Web Mar 4, 2026 at 11:02 pm

@claude
Copy link

claude bot commented Mar 4, 2026

PR Review: feat: add deployments route

This PR adds a deployments route to the Rivet Cloud dashboard, including managed pool support, Docker image browsing, deployment logs streaming, a Rivet Cloud onboarding flow, and several stepper form improvements. The overall approach is sound, but there are a few issues worth addressing.


Bugs

Inverted validation condition in upsert-deployment-form.tsx: The superRefine check has the condition backwards. It reports an error when both repository and tag are present, which is the valid case. The correct condition should be if (data.image.repository AND NOT data.image.tag). As written, this will prevent users from ever submitting a valid image selection.

Debug console.log left in production code: frontend/src/app/forms/upsert-deployment-form.tsx has console.log(data) inside the superRefine validator and should be removed before merge.


Security Concern

API token creation via a query: In connect-rivet-frame.tsx and getting-started.tsx, createApiTokenQueryOptions uses queryOptions with staleTime: Infinity but token creation is a mutation (POST), not a GET. This should be a useMutation triggered by explicit user action. Additionally the token is shown without masking - consider masking by default with a reveal toggle.


Code Quality

DeploymentCheck form context: deployment-check.tsx calls useController internally without an explicit FormProvider. If rendered outside react-hook-form context it will throw.

Duplicate PoolStatus: Defined independently in both deployment-check.tsx and connect-rivet-frame.tsx. Extract to a shared component.

getValues() in render: Called during render in stepper-form.tsx to compute visibleSteps. Does not subscribe to updates - use useWatch instead.

DeploymentsLink missing Suspense: CloudSidebarContentInner renders DeploymentsLink which calls useSuspenseQuery without a wrapping Suspense boundary.

Font change bundled: Switching from Manrope to Open Sans affects the entire dashboard. Hard to isolate and revert independently.


Minor Issues

displayBackendOnboarding logic appears inverted when pool is ready. Indentation in data.ts uses 4-space instead of tabs. Missing trailing newline in frontend/src/lib/data.ts. Extra blank line in use-dialog.tsx at line 267. maxPages: Infinity on polling queries will eagerly fetch all pages on every poll interval.


Summary

Severity Issue
Bug Inverted tag-required validation in upsert-deployment-form.tsx
Debug console.log left in production code
Security Token creation as a query; token shown without masking
Logic displayBackendOnboarding condition appears inverted
Rendering getValues() in render does not react to form value changes
Suspense DeploymentsLink missing Suspense boundary in sidebar
Quality Duplicate PoolStatus components; implicit form context dependency
Style 4-space indentation in data.ts; missing trailing newline

Generated with Claude Code

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 4, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4357

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4357

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4357

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4357

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4357

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4357

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4357

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4357

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4357

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4357

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4357

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4357

commit: f28c507

@jog1t jog1t force-pushed the feat/debug-inspector-info branch from d1a420b to f20ed36 Compare March 11, 2026 13:41
@jog1t jog1t force-pushed the feat/deployments branch from bfb3937 to 853f453 Compare March 11, 2026 13:41
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4357 March 11, 2026 13:41 Destroyed
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4357 March 11, 2026 15:59 Destroyed
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4357 March 11, 2026 20:38 Destroyed
@jog1t jog1t marked this pull request as ready for review March 11, 2026 22:03
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4357 March 11, 2026 22:03 Destroyed
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4357 March 11, 2026 22:10 Destroyed
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4357 March 12, 2026 22:54 Destroyed
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4357 March 13, 2026 18:43 Destroyed
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4357 March 13, 2026 18:51 Destroyed
@jog1t jog1t merged commit c1508a9 into feat/debug-inspector-info Mar 13, 2026
13 of 18 checks passed
@jog1t jog1t deleted the feat/deployments branch March 13, 2026 18:59
jog1t added a commit that referenced this pull request Mar 13, 2026
… fails to load (#4346)

* feat/debug-inspector-info

* feat: add deployments route (#4357)

* feat: add deployments route

* new endpoints

* feat: deployments

* feat: deployments

* fix ts issues

* fix

* fix

* fixes

* fixes

* fixes

* fixes

* fixes
jog1t added a commit that referenced this pull request Mar 13, 2026
* fix/firefox-modals

* feat(frontend): add additional debug information when actor inspector fails to load (#4346)

* feat/debug-inspector-info

* feat: add deployments route (#4357)

* feat: add deployments route

* new endpoints

* feat: deployments

* feat: deployments

* fix ts issues

* fix

* fix

* fixes

* fixes

* fixes

* fixes

* fixes
jog1t added a commit that referenced this pull request Mar 13, 2026
* fix/runner-configs-outdated

* fix cache management

* fix: modals being stuck opaque on firefox (#4344)

* fix/firefox-modals

* feat(frontend): add additional debug information when actor inspector fails to load (#4346)

* feat/debug-inspector-info

* feat: add deployments route (#4357)

* feat: add deployments route

* new endpoints

* feat: deployments

* feat: deployments

* fix ts issues

* fix

* fix

* fixes

* fixes

* fixes

* fixes

* fixes
jog1t added a commit that referenced this pull request Mar 13, 2026
* fix/docs-button

* fix: invalid docs link

* fix: runner configs being outdated when editing again (#4343)

* fix/runner-configs-outdated

* fix cache management

* fix: modals being stuck opaque on firefox (#4344)

* fix/firefox-modals

* feat(frontend): add additional debug information when actor inspector fails to load (#4346)

* feat/debug-inspector-info

* feat: add deployments route (#4357)

* feat: add deployments route

* new endpoints

* feat: deployments

* feat: deployments

* fix ts issues

* fix

* fix

* fixes

* fixes

* fixes

* fixes

* fixes
jog1t added a commit that referenced this pull request Mar 13, 2026
* fix/new-project-incorrect-redirect

* fix: incorrect redirection after project creation in cloud onboarding

* fix: docs-button (#4342)

* fix/docs-button

* fix: invalid docs link

* fix: runner configs being outdated when editing again (#4343)

* fix/runner-configs-outdated

* fix cache management

* fix: modals being stuck opaque on firefox (#4344)

* fix/firefox-modals

* feat(frontend): add additional debug information when actor inspector fails to load (#4346)

* feat/debug-inspector-info

* feat: add deployments route (#4357)

* feat: add deployments route

* new endpoints

* feat: deployments

* feat: deployments

* fix ts issues

* fix

* fix

* fixes

* fixes

* fixes

* fixes

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant