feat: add deployments route#4357
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
🚅 Deployed to the rivet-pr-4357 environment in rivet-frontend
|
|
PR Review: feat: add deployments route This PR adds a deployments route to the Rivet Cloud dashboard, including managed pool support, Docker image browsing, deployment logs streaming, a Rivet Cloud onboarding flow, and several stepper form improvements. The overall approach is sound, but there are a few issues worth addressing. Bugs Inverted validation condition in upsert-deployment-form.tsx: The superRefine check has the condition backwards. It reports an error when both repository and tag are present, which is the valid case. The correct condition should be if (data.image.repository AND NOT data.image.tag). As written, this will prevent users from ever submitting a valid image selection. Debug console.log left in production code: frontend/src/app/forms/upsert-deployment-form.tsx has console.log(data) inside the superRefine validator and should be removed before merge. Security Concern API token creation via a query: In connect-rivet-frame.tsx and getting-started.tsx, createApiTokenQueryOptions uses queryOptions with staleTime: Infinity but token creation is a mutation (POST), not a GET. This should be a useMutation triggered by explicit user action. Additionally the token is shown without masking - consider masking by default with a reveal toggle. Code Quality DeploymentCheck form context: deployment-check.tsx calls useController internally without an explicit FormProvider. If rendered outside react-hook-form context it will throw. Duplicate PoolStatus: Defined independently in both deployment-check.tsx and connect-rivet-frame.tsx. Extract to a shared component. getValues() in render: Called during render in stepper-form.tsx to compute visibleSteps. Does not subscribe to updates - use useWatch instead. DeploymentsLink missing Suspense: CloudSidebarContentInner renders DeploymentsLink which calls useSuspenseQuery without a wrapping Suspense boundary. Font change bundled: Switching from Manrope to Open Sans affects the entire dashboard. Hard to isolate and revert independently. Minor Issues displayBackendOnboarding logic appears inverted when pool is ready. Indentation in data.ts uses 4-space instead of tabs. Missing trailing newline in frontend/src/lib/data.ts. Extra blank line in use-dialog.tsx at line 267. maxPages: Infinity on polling queries will eagerly fetch all pages on every poll interval. Summary
Generated with Claude Code |
69e7656 to
d1a420b
Compare
d1a420b to
f20ed36
Compare
* fix/firefox-modals * feat(frontend): add additional debug information when actor inspector fails to load (#4346) * feat/debug-inspector-info * feat: add deployments route (#4357) * feat: add deployments route * new endpoints * feat: deployments * feat: deployments * fix ts issues * fix * fix * fixes * fixes * fixes * fixes * fixes
* fix/runner-configs-outdated * fix cache management * fix: modals being stuck opaque on firefox (#4344) * fix/firefox-modals * feat(frontend): add additional debug information when actor inspector fails to load (#4346) * feat/debug-inspector-info * feat: add deployments route (#4357) * feat: add deployments route * new endpoints * feat: deployments * feat: deployments * fix ts issues * fix * fix * fixes * fixes * fixes * fixes * fixes
* fix/docs-button * fix: invalid docs link * fix: runner configs being outdated when editing again (#4343) * fix/runner-configs-outdated * fix cache management * fix: modals being stuck opaque on firefox (#4344) * fix/firefox-modals * feat(frontend): add additional debug information when actor inspector fails to load (#4346) * feat/debug-inspector-info * feat: add deployments route (#4357) * feat: add deployments route * new endpoints * feat: deployments * feat: deployments * fix ts issues * fix * fix * fixes * fixes * fixes * fixes * fixes
* fix/new-project-incorrect-redirect * fix: incorrect redirection after project creation in cloud onboarding * fix: docs-button (#4342) * fix/docs-button * fix: invalid docs link * fix: runner configs being outdated when editing again (#4343) * fix/runner-configs-outdated * fix cache management * fix: modals being stuck opaque on firefox (#4344) * fix/firefox-modals * feat(frontend): add additional debug information when actor inspector fails to load (#4346) * feat/debug-inspector-info * feat: add deployments route (#4357) * feat: add deployments route * new endpoints * feat: deployments * feat: deployments * fix ts issues * fix * fix * fixes * fixes * fixes * fixes * fixes
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: