fix: modals being stuck opaque on firefox#4344
fix: modals being stuck opaque on firefox#4344jog1t merged 3 commits intofix-runner-configs-outdatedfrom
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
🚅 Deployed to the rivet-pr-4344 environment in rivet-frontend
|
|
PR Review: fix: modals being stuck opaque on firefox SUMMARY: BUGS:
CODE QUALITY:
POSITIVE CHANGES:
|
284188a to
eaf16db
Compare
9312097 to
e97a31a
Compare
eaf16db to
d68e1f0
Compare
e97a31a to
a10371b
Compare
* fix/runner-configs-outdated * fix cache management * fix: modals being stuck opaque on firefox (#4344) * fix/firefox-modals * feat(frontend): add additional debug information when actor inspector fails to load (#4346) * feat/debug-inspector-info * feat: add deployments route (#4357) * feat: add deployments route * new endpoints * feat: deployments * feat: deployments * fix ts issues * fix * fix * fixes * fixes * fixes * fixes * fixes
* fix/docs-button * fix: invalid docs link * fix: runner configs being outdated when editing again (#4343) * fix/runner-configs-outdated * fix cache management * fix: modals being stuck opaque on firefox (#4344) * fix/firefox-modals * feat(frontend): add additional debug information when actor inspector fails to load (#4346) * feat/debug-inspector-info * feat: add deployments route (#4357) * feat: add deployments route * new endpoints * feat: deployments * feat: deployments * fix ts issues * fix * fix * fixes * fixes * fixes * fixes * fixes
* fix/new-project-incorrect-redirect * fix: incorrect redirection after project creation in cloud onboarding * fix: docs-button (#4342) * fix/docs-button * fix: invalid docs link * fix: runner configs being outdated when editing again (#4343) * fix/runner-configs-outdated * fix cache management * fix: modals being stuck opaque on firefox (#4344) * fix/firefox-modals * feat(frontend): add additional debug information when actor inspector fails to load (#4346) * feat/debug-inspector-info * feat: add deployments route (#4357) * feat: add deployments route * new endpoints * feat: deployments * feat: deployments * fix ts issues * fix * fix * fixes * fixes * fixes * fixes * fixes
Fixes RVT-5902
This pull request refactors dialog animation logic and improves modal state management in the cloud context. The most notable changes are the migration of dialog animations from utility classes to CSS keyframes, resulting in cleaner React component code, and the simplification of URL search state updates when closing cloud modals.
Dialog UI and Animation Refactor:
dialog.module.css, replacing previous utility-based animation classes.dialog.tsxto use new CSS module classes for dialog overlay and content, removing complex utility class logic and improving maintainability. [1] [2] [3]Cloud Modal State Management:
_cloud.tsxby removing unnecessary properties (organization,dc,config,displayName) from the URL search state when closing modals, ensuring only relevant modal state is cleared. [1] [2] [3] [4] [5]