Skip to content

fix: modals being stuck opaque on firefox#4344

Merged
jog1t merged 3 commits intofix-runner-configs-outdatedfrom
fix/firefox-modals
Mar 13, 2026
Merged

fix: modals being stuck opaque on firefox#4344
jog1t merged 3 commits intofix-runner-configs-outdatedfrom
fix/firefox-modals

Conversation

@jog1t
Copy link
Contributor

@jog1t jog1t commented Mar 3, 2026

Fixes RVT-5902

This pull request refactors dialog animation logic and improves modal state management in the cloud context. The most notable changes are the migration of dialog animations from utility classes to CSS keyframes, resulting in cleaner React component code, and the simplification of URL search state updates when closing cloud modals.

Dialog UI and Animation Refactor:

  • Added custom keyframe animations for dialog overlay and content transitions to dialog.module.css, replacing previous utility-based animation classes.
  • Updated dialog.tsx to use new CSS module classes for dialog overlay and content, removing complex utility class logic and improving maintainability. [1] [2] [3]

Cloud Modal State Management:

  • Simplified the state update logic in _cloud.tsx by removing unnecessary properties (organization, dc, config, displayName) from the URL search state when closing modals, ensuring only relevant modal state is cleared. [1] [2] [3] [4] [5]

@jog1t
Copy link
Contributor Author

jog1t commented Mar 3, 2026

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4344 March 3, 2026 22:41 Destroyed
@railway-app
Copy link

railway-app bot commented Mar 3, 2026

🚅 Deployed to the rivet-pr-4344 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-inspector 😴 Sleeping (View Logs) Web Mar 11, 2026 at 10:14 pm
frontend-cloud 😴 Sleeping (View Logs) Web Mar 11, 2026 at 10:12 pm
ladle ❌ Build Failed (View Logs) Web Mar 11, 2026 at 1:41 pm
website 😴 Sleeping (View Logs) Web Mar 3, 2026 at 10:50 pm
mcp-hub ✅ Success (View Logs) Web Mar 3, 2026 at 10:41 pm

@linear
Copy link

linear bot commented Mar 3, 2026

@jog1t jog1t changed the title fix/firefox-modals fix: modals being stuck opaque on firefox Mar 3, 2026
@claude
Copy link

claude bot commented Mar 3, 2026

PR Review: fix: modals being stuck opaque on firefox

SUMMARY:
This PR fixes the Firefox opacity issue by migrating dialog animations from Tailwind utility classes to CSS keyframes/modules. It also includes Rivet Cloud compute integration UI, font migration from Manrope to Open Sans, Slider/Stepper fixes, and modal state management improvements.

BUGS:

  1. upsert-deployment-form.tsx - Inverted validation logic in superRefine
    The condition is inverted. Current code fires when tag IS provided (wrong). Should fire when tag is MISSING:
  • Wrong: if (data.image.repository && !!data.image.tag)
  • Right: if (data.image.repository && !data.image.tag)
  1. upsert-deployment-form.tsx - Debug console.log left in production code inside superRefine

CODE QUALITY:

  1. connect-rivet-frame.tsx - Mutation fires automatically on mount via useEffect with upsertManagedPool. If this is intentional (setup wizard), a comment would help.

  2. upsert-deployment-frame.tsx - Hardcoded maxCount: 1000, minCount: 0, displayName: "default" without user input. Should use named constants.

POSITIVE CHANGES:

  • Dialog animation fix using CSS keyframes correctly addresses the Firefox incompatibility with Tailwind animate-in/animate-out utilities
  • Modal state cleanup removing organization, dc, config, displayName from URL search on close
  • FIXME removal with proper types replacing value: any casts
  • Slider fix handling both value and defaultValue for controlled/uncontrolled usage
  • Stepper visibility with StepVisibilityContext is clean
  • actor-inspector-context.tsx type field addition matches router.ts

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 3, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4344

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4344

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4344

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4344

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4344

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4344

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4344

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4344

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4344

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4344

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4344

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4344

commit: df026c5

@jog1t jog1t force-pushed the fix-runner-configs-outdated branch from eaf16db to d68e1f0 Compare March 11, 2026 13:40
@jog1t jog1t force-pushed the fix/firefox-modals branch from e97a31a to a10371b Compare March 11, 2026 13:40
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4344 March 11, 2026 13:40 Destroyed
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4344 March 11, 2026 22:02 Destroyed
… fails to load (#4346)

* feat/debug-inspector-info

* feat: add deployments route (#4357)

* feat: add deployments route

* new endpoints

* feat: deployments

* feat: deployments

* fix ts issues

* fix

* fix

* fixes

* fixes

* fixes

* fixes

* fixes
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4344 March 13, 2026 18:59 Destroyed
@jog1t jog1t merged commit 402f393 into fix-runner-configs-outdated Mar 13, 2026
8 of 12 checks passed
@jog1t jog1t deleted the fix/firefox-modals branch March 13, 2026 18:59
jog1t added a commit that referenced this pull request Mar 13, 2026
* fix/runner-configs-outdated

* fix cache management

* fix: modals being stuck opaque on firefox (#4344)

* fix/firefox-modals

* feat(frontend): add additional debug information when actor inspector fails to load (#4346)

* feat/debug-inspector-info

* feat: add deployments route (#4357)

* feat: add deployments route

* new endpoints

* feat: deployments

* feat: deployments

* fix ts issues

* fix

* fix

* fixes

* fixes

* fixes

* fixes

* fixes
jog1t added a commit that referenced this pull request Mar 13, 2026
* fix/docs-button

* fix: invalid docs link

* fix: runner configs being outdated when editing again (#4343)

* fix/runner-configs-outdated

* fix cache management

* fix: modals being stuck opaque on firefox (#4344)

* fix/firefox-modals

* feat(frontend): add additional debug information when actor inspector fails to load (#4346)

* feat/debug-inspector-info

* feat: add deployments route (#4357)

* feat: add deployments route

* new endpoints

* feat: deployments

* feat: deployments

* fix ts issues

* fix

* fix

* fixes

* fixes

* fixes

* fixes

* fixes
jog1t added a commit that referenced this pull request Mar 13, 2026
* fix/new-project-incorrect-redirect

* fix: incorrect redirection after project creation in cloud onboarding

* fix: docs-button (#4342)

* fix/docs-button

* fix: invalid docs link

* fix: runner configs being outdated when editing again (#4343)

* fix/runner-configs-outdated

* fix cache management

* fix: modals being stuck opaque on firefox (#4344)

* fix/firefox-modals

* feat(frontend): add additional debug information when actor inspector fails to load (#4346)

* feat/debug-inspector-info

* feat: add deployments route (#4357)

* feat: add deployments route

* new endpoints

* feat: deployments

* feat: deployments

* fix ts issues

* fix

* fix

* fixes

* fixes

* fixes

* fixes

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant