Skip to content

Set per-header visibility for imagemanager Apple headers (#58878) #58878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 1 commit into from
Closed

Set per-header visibility for imagemanager Apple headers (#58878) #58878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/React/Fabric/RCTImageResponseObserverProxy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#import "RCTImageResponseDelegate.h"

#include <react/renderer/imagemanager/ImageResponseObserver.h>
#include <React/ImageManager.h>

NS_ASSUME_NONNULL_BEGIN

Expand Down
2 changes: 2 additions & 0 deletions ...on/react/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImageManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/PrivateGuard.h>

#import <UIKit/UIKit.h>

#import "RCTImageManagerProtocol.h"
Expand Down
2 changes: 2 additions & 0 deletions .../renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImageManagerProtocol.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/PrivateGuard.h>

#import <Foundation/Foundation.h>
#import <React/RendererCore.h>
#import <react/renderer/imagemanager/ImageRequest.h>
Expand Down
4 changes: 3 additions & 1 deletion ...rer/imagemanager/platform/ios/react/renderer/imagemanager/RCTImagePrimitivesConversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,13 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/FrameworksGuard.h>

#import <UIKit/UIKit.h>

#import <React/ImageManager.h>
#import <React/RCTConvert.h>
#import <React/RCTImageLoader.h>
#import <react/renderer/imagemanager/primitives.h>

inline static UIViewContentMode RCTContentModeFromImageResizeMode(facebook::react::ImageResizeMode imageResizeMode)
{
Expand Down
2 changes: 2 additions & 0 deletions ...eact/renderer/imagemanager/platform/ios/react/renderer/imagemanager/RCTSyncImageManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree.
*/

#include <react/cxxstableapi/PrivateGuard.h>

#import <UIKit/UIKit.h>

#import "RCTImageManagerProtocol.h"
Expand Down
14 changes: 0 additions & 14 deletions scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,11 +1173,6 @@ interface RCTImageLoader : public NSObject <RCTBridgeModule, RCTImageLoaderProto
public virtual instancetype initWithRedirectDelegate:loadersProvider:decodersProvider:(id<RCTImageRedirectProtocol> redirectDelegate, NSArray<id<RCTImageURLLoader>>*(^)(RCTModuleRegistry*) getLoaders, NSArray<id<RCTImageDataDecoder>>*(^)(RCTModuleRegistry*) getDecoders);
}

interface RCTImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}

interface RCTImageSource : public NSObject {
public @property (assign, readonly) CGFloat scale;
public @property (assign, readonly) CGSize size;
Expand Down Expand Up @@ -1897,11 +1892,6 @@ interface RCTSwiftUIContainerViewWrapper : public NSObject {
interface RCTSwitchComponentView : public RCTViewComponentView {
}

interface RCTSyncImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}

interface RCTTextInputComponentView : public RCTViewComponentView {
}

Expand Down Expand Up @@ -2767,10 +2757,6 @@ protocol RCTImageLoaderWithAttributionProtocol : public RCTImageLoaderProtocol,
public virtual void trackURLImageVisibilityForRequest:imageView:(RCTImageURLLoaderRequest* loaderRequest, UIView* imageView);
}

protocol RCTImageManagerProtocol : public NSObject {
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
}

protocol RCTImageRedirectProtocol {
public virtual NSURL* redirectAssetsURL:(NSURL* URL);
}
Expand Down
14 changes: 0 additions & 14 deletions scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,11 +1196,6 @@ interface RCTImageLoader : public NSObject <RCTBridgeModule, RCTImageLoaderProto
public virtual instancetype initWithRedirectDelegate:loadersProvider:decodersProvider:(id<RCTImageRedirectProtocol> redirectDelegate, NSArray<id<RCTImageURLLoader>>*(^)(RCTModuleRegistry*) getLoaders, NSArray<id<RCTImageDataDecoder>>*(^)(RCTModuleRegistry*) getDecoders);
}

interface RCTImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}

interface RCTImageSource : public NSObject {
public @property (assign, readonly) CGFloat scale;
public @property (assign, readonly) CGSize size;
Expand Down Expand Up @@ -1940,11 +1935,6 @@ interface RCTSwiftUIContainerViewWrapper : public NSObject {
interface RCTSwitchComponentView : public RCTViewComponentView {
}

interface RCTSyncImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}

interface RCTTextInputComponentView : public RCTViewComponentView {
}

Expand Down Expand Up @@ -2835,10 +2825,6 @@ protocol RCTImageLoaderWithAttributionProtocol : public RCTImageLoaderProtocol,
public virtual void trackURLImageVisibilityForRequest:imageView:(RCTImageURLLoaderRequest* loaderRequest, UIView* imageView);
}

protocol RCTImageManagerProtocol : public NSObject {
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
}

protocol RCTImageRedirectProtocol {
public virtual NSURL* redirectAssetsURL:(NSURL* URL);
}
Expand Down
14 changes: 0 additions & 14 deletions scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,11 +1173,6 @@ interface RCTImageLoader : public NSObject <RCTBridgeModule, RCTImageLoaderProto
public virtual instancetype initWithRedirectDelegate:loadersProvider:decodersProvider:(id<RCTImageRedirectProtocol> redirectDelegate, NSArray<id<RCTImageURLLoader>>*(^)(RCTModuleRegistry*) getLoaders, NSArray<id<RCTImageDataDecoder>>*(^)(RCTModuleRegistry*) getDecoders);
}

interface RCTImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}

interface RCTImageSource : public NSObject {
public @property (assign, readonly) CGFloat scale;
public @property (assign, readonly) CGSize size;
Expand Down Expand Up @@ -1890,11 +1885,6 @@ interface RCTSwiftUIContainerViewWrapper : public NSObject {
interface RCTSwitchComponentView : public RCTViewComponentView {
}

interface RCTSyncImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}

interface RCTTextInputComponentView : public RCTViewComponentView {
}

Expand Down Expand Up @@ -2759,10 +2749,6 @@ protocol RCTImageLoaderWithAttributionProtocol : public RCTImageLoaderProtocol,
public virtual void trackURLImageVisibilityForRequest:imageView:(RCTImageURLLoaderRequest* loaderRequest, UIView* imageView);
}

protocol RCTImageManagerProtocol : public NSObject {
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
}

protocol RCTImageRedirectProtocol {
public virtual NSURL* redirectAssetsURL:(NSURL* URL);
}
Expand Down
14 changes: 0 additions & 14 deletions scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,11 +1173,6 @@ interface RCTImageLoader : public NSObject <RCTBridgeModule, RCTImageLoaderProto
public virtual instancetype initWithRedirectDelegate:loadersProvider:decodersProvider:(id<RCTImageRedirectProtocol> redirectDelegate, NSArray<id<RCTImageURLLoader>>*(^)(RCTModuleRegistry*) getLoaders, NSArray<id<RCTImageDataDecoder>>*(^)(RCTModuleRegistry*) getDecoders);
}

interface RCTImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}

interface RCTImageSource : public NSObject {
public @property (assign, readonly) CGFloat scale;
public @property (assign, readonly) CGSize size;
Expand Down Expand Up @@ -1897,11 +1892,6 @@ interface RCTSwiftUIContainerViewWrapper : public NSObject {
interface RCTSwitchComponentView : public RCTViewComponentView {
}

interface RCTSyncImageManager : public NSObject <RCTImageManagerProtocol> {
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
public virtual instancetype initWithImageLoader:(id<RCTImageLoaderWithAttributionProtocol> imageLoader);
}

interface RCTTextInputComponentView : public RCTViewComponentView {
}

Expand Down Expand Up @@ -2767,10 +2757,6 @@ protocol RCTImageLoaderWithAttributionProtocol : public RCTImageLoaderProtocol,
public virtual void trackURLImageVisibilityForRequest:imageView:(RCTImageURLLoaderRequest* loaderRequest, UIView* imageView);
}

protocol RCTImageManagerProtocol : public NSObject {
public virtual facebook::react::ImageRequest requestImage:surfaceId:(facebook::react::ImageSource imageSource, facebook::react::SurfaceId surfaceId);
}

protocol RCTImageRedirectProtocol {
public virtual NSURL* redirectAssetsURL:(NSURL* URL);
}
Expand Down
Loading