Repository navigation
Set per-header visibility for imagemanager Apple headers (#58878) - #58878
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123594275. |
Summary: Makes `RCTImageManager.h`, `RCTSyncImageManager.h` and `RCTImageManagerProtocol.h` private and `RCTImagePrimitivesConversions.h` "for frameworks". `RCTImagePrimitivesConversions.h` and `RCTImageResponseObserverProxy.h` now include the public `<React/ImageManager.h>` umbrella so they don't trip its guard under `RN_STRICT_API`. The guards are inert without that flag. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D123594275
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D123594275
branch
from
October 9, 2026 08:16
8328b42 to
e8848ea
Compare
|
This pull request has been merged in 456fc97. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Makes
RCTImageManager.h,RCTSyncImageManager.handRCTImageManagerProtocol.hprivate andRCTImagePrimitivesConversions.h"for frameworks".RCTImagePrimitivesConversions.handRCTImageResponseObserverProxy.hnow include the public<React/ImageManager.h>umbrella so they don't trip its guard underRN_STRICT_API. The guards are inert without that flag.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D123594275