Add join handler#720
Merged
Merged
Conversation
Seggan
approved these changes
May 3, 2026
LordIdra
requested changes
May 10, 2026
Contributor
LordIdra
left a comment
LordIdra
left a comment
There was a problem hiding this comment.
Small thing but why is this only called for non-first-time-players? If a player spawns with an item in their inventory e.g. as part of a kit surely we'd want to call this then as well, deliberately excluding this as an edge case seems redundant
LordIdra
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to pylonmc/pylon#970