[ref:balugaq/rebar-rejoin-handler] Add rejoin handler#970
Merged
Conversation
Collaborator
Author
|
tested |
Seggan
reviewed
May 3, 2026
| if (!event.getPlayer().getPersistentDataContainer().has(PylonKeys.FLIGHT_RING)) { | ||
| return; | ||
| } | ||
| for (ItemStack stack : event.getPlayer().getInventory()) { |
Member
There was a problem hiding this comment.
Why are you iterating the inventory when the rejoin handler already does that?
Contributor
|
This & the rebar PR are also gonna need to be updated with my performance PR |
Seggan
approved these changes
May 12, 2026
Contributor
|
I found a large number of issues with the original handler and reworked it - have pushed corresponding changes to this PR |
Seggan
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to pylonmc/rebar#720
Closes #899