Repository navigation
fix(docs): install spatialmath and pgraph with deps=False in JupyterLite - #133
Merged
Merged
Conversation
spatialmath-python 1.1.18 lists pre-commit as a runtime dependency; its virtualenv requires packaging>=26.3, which conflicts with the packaging 24.2 built into Pyodide, so micropip.install fails in the browser and the docs build's Pyodide install check goes red. pgraph-python depends on spatialmath-python so has the same problem. Install both with deps=False and list their real runtime dependencies in the seed list. Remove once spatialmath drops the dependency (rai-opensource/spatialmath-python#250) and a release is out. Notebook bootstrap cells regenerated with sync_bootstrap.py. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The docs `build` check (and the live in-browser demo) fails: `micropip.install('spatialmath-python')` raises `ValueError: Requested 'packaging>=26.3', but packaging==24.2 is already installed`.
Cause: spatialmath-python 1.1.18 lists `pre-commit` (a dev tool) as a runtime dependency; `pre-commit` -> `virtualenv` 21.14.7 -> `packaging>=26.3`, and Pyodide ships `packaging` 24.2. It started failing when virtualenv 21.14.7 was published, with no change in this repo. RTB and bdsim fail the same way (reproduced in Pyodide 0.27.6).
Upstream fix: rai-opensource/spatialmath-python#250.
Change
In `docs/notebooks/_mvtb_nb_bootstrap.py`, install `spatialmath-python` and `pgraph-python` (which depends on spatialmath) with `deps=False`, and add their real runtime dependencies (numpy, scipy, matplotlib, typing_extensions) to the seed list. Notebook bootstrap cells regenerated with `sync_bootstrap.py`.
Temporary: revert once a spatialmath release without that dependency is out.
Testing
🤖 Generated with Claude Code