[infra] offer M3ED-SPOT in the provisioning workflow - #159
Conversation
m3ed_spot has been provisionable since #158 but was unreachable: the dispatch input is a static choice list, so a registry entry alone does not appear in the UI. It needs no dataset-specific image. The TartanAir toolbox image and the x86-only runner guard are selected by literal equality with 'tartan', so M3ED runs on cuvslam-ci:local, and provision_dataset.sh installs the tools package that carries its numpy, Pillow and h5py. CODa stays unlisted. Its preparation converts archives fetched by hand, so a dispatch would fail without a pre-seeded raw directory.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe provisioning workflow now allows users to select the ChangesDataset Provisioning
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The workflow now exposes M3ED-SPOT for provisioning through the existing dataset implementation. The selected value is supported by current validation and preparation paths, with no remaining merge-readiness risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Test Results
cuVSLAM Evaluation KPIs
Artifacts |
m3ed_spot has been provisionable since #158 but was unreachable: the dispatch input is a static choice list, so a registry entry alone does not appear in the UI.
It needs no dataset-specific image. The TartanAir toolbox image and the x86-only runner guard are selected by literal equality with 'tartan', so M3ED runs on cuvslam-ci:local, and provision_dataset.sh installs the tools package that carries its numpy, Pillow and h5py.
CODa stays unlisted. Its preparation converts archives fetched by hand, so a dispatch would fail without a pre-seeded raw directory.
Summary by CodeRabbit
m3ed_spotas a selectable dataset option when provisioning datasets.