Skip to content

[infra] offer M3ED-SPOT in the provisioning workflow - #159

Merged
vikuznetsov-nvidia merged 1 commit into
mainfrom
vikuznetsov/offer-m3ed-spot-provisioning
Sep 9, 2026
Merged

[infra] offer M3ED-SPOT in the provisioning workflow#159
vikuznetsov-nvidia merged 1 commit into
mainfrom
vikuznetsov/offer-m3ed-spot-provisioning

Conversation

@vikuznetsov-nvidia

@vikuznetsov-nvidia vikuznetsov-nvidia commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

m3ed_spot has been provisionable since #158 but was unreachable: the dispatch input is a static choice list, so a registry entry alone does not appear in the UI.

It needs no dataset-specific image. The TartanAir toolbox image and the x86-only runner guard are selected by literal equality with 'tartan', so M3ED runs on cuvslam-ci:local, and provision_dataset.sh installs the tools package that carries its numpy, Pillow and h5py.

CODa stays unlisted. Its preparation converts archives fetched by hand, so a dispatch would fail without a pre-seeded raw directory.

Summary by CodeRabbit

  • New Features
    • Added m3ed_spot as a selectable dataset option when provisioning datasets.

m3ed_spot has been provisionable since #158 but was unreachable: the
dispatch input is a static choice list, so a registry entry alone does
not appear in the UI.

It needs no dataset-specific image. The TartanAir toolbox image and the
x86-only runner guard are selected by literal equality with 'tartan', so
M3ED runs on cuvslam-ci:local, and provision_dataset.sh installs the
tools package that carries its numpy, Pillow and h5py.

CODa stays unlisted. Its preparation converts archives fetched by hand,
so a dispatch would fail without a pre-seeded raw directory.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: f9c89fc9-1013-4d43-95db-4a4240f7d344

📥 Commits

Reviewing files that changed from the base of the PR and between 69e2f29 and 977969d.

📒 Files selected for processing (1)
  • .github/workflows/provision-datasets.yml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The provisioning workflow now allows users to select the m3ed_spot dataset.

Changes

Dataset Provisioning

Layer / File(s) Summary
Add dataset choice
.github/workflows/provision-datasets.yml
Adds m3ed_spot to the workflow-dispatch dataset choices.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 97796

The workflow now exposes M3ED-SPOT for provisioning through the existing dataset implementation. The selected value is supported by current validation and preparation paths, with no remaining merge-readiness risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: adding M3ED-SPOT as an option in the provisioning workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vikuznetsov/offer-m3ed-spot-provisioning

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Test Results

Status Platform Language Total Passed Failed Errors Skipped
Orin C++ 17 17 0 0 0
Orin Python 74 73 0 0 1
Thor C++ 17 17 0 0 0
Thor Python 74 73 0 0 1
x86_64 C++ 17 17 0 0 0
x86_64 Python 74 73 0 0 1

cuVSLAM Evaluation KPIs

Config Dataset ATE, % ARE, º/m Kabsch Losts diff ATE, % diff ARE, º/m diff Kabsch diff Losts FPS, Hz
x86_64-cuda12.6.3-ubuntu24.04 EUROC-VIO_ODOM 1.6516 0.1497 0.0943 0 0.0017 0.0002 -0.0016 0 119.9
x86_64-cuda12.6.3-ubuntu24.04 EUROC-VIO_SLAM 1.7875 0.1925 0.0596 0 0.0027 -0.0003 0.0001 0 99.1
x86_64-cuda12.6.3-ubuntu24.04 ICL_NUIM-RGBD_ODOM 1.8280 0.3368 0.0308 0 NA NA NA NA 69.8
x86_64-cuda12.6.3-ubuntu24.04 ICL_NUIM-RGBD_SLAM 1.4058 0.2645 0.0193 0 NA NA NA NA 71.1
x86_64-cuda12.6.3-ubuntu24.04 KITTI-STEREO_ODOM 0.8231 0.0024 2.8030 0 0.0115 0.0000 -0.0024 0 242.7
x86_64-cuda12.6.3-ubuntu24.04 KITTI-STEREO_SLAM 0.7264 0.0019 1.8860 0 -0.0006 -0.0000 -0.0128 0 173.6

Artifacts

@vikuznetsov-nvidia
vikuznetsov-nvidia merged commit 23a774e into main Sep 9, 2026
12 of 14 checks passed
@vikuznetsov-nvidia
vikuznetsov-nvidia deleted the vikuznetsov/offer-m3ed-spot-provisioning branch September 9, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants