Skip to content

Upgrade astro and its related dependencies for ENSNode Docs website #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tk-o wants to merge 1 commit into from
Closed

Upgrade astro and its related dependencies for ENSNode Docs website #1979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions docs/ensnode.io/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
"generate:openapi": "pnpm --filter ensapi exec tsx --tsconfig tsconfig.json ../../scripts/generate-ensapi-openapi.mts"
},
"dependencies": {
"@astrojs/mdx": "^4.3.9",
"@astrojs/mdx": "^5.0.3",
"@astrojs/react": "catalog:",
"@astrojs/sitemap": "^3.6.0",
"@astrojs/starlight": "^0.36.1",
"@astrojs/starlight-tailwind": "^4.0.1",
"@astrojs/sitemap": "^3.7.2",
"@astrojs/starlight": "^0.38.3",
"@astrojs/starlight-tailwind": "^5.0.0",
Comment on lines +19 to +23
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Consider moving these Astro ecosystem versions into the workspace catalog.

Keeping Astro-adjacent versions centralized reduces drift across docs packages during future framework upgrades.

📦 Suggested catalog refactor 
# pnpm-workspace.yaml
 catalog:
+  "@astrojs/mdx": ^5.0.3
+  "@astrojs/sitemap": ^3.7.2
+  "@astrojs/starlight": ^0.38.3
+  "@astrojs/starlight-tailwind": ^5.0.0
+  "astro-mermaid": ^2.0.1
+  "starlight-llms-txt": ^0.8.1
+  "starlight-sidebar-topics": ^0.7.1

# docs/ensnode.io/package.json
- "@astrojs/mdx": "^5.0.3",
+ "@astrojs/mdx": "catalog:",
- "@astrojs/sitemap": "^3.7.2",
+ "@astrojs/sitemap": "catalog:",
- "@astrojs/starlight": "^0.38.3",
+ "@astrojs/starlight": "catalog:",
- "@astrojs/starlight-tailwind": "^5.0.0",
+ "@astrojs/starlight-tailwind": "catalog:",
- "astro-mermaid": "^2.0.1",
+ "astro-mermaid": "catalog:",
- "starlight-llms-txt": "^0.8.1",
+ "starlight-llms-txt": "catalog:",
- "starlight-sidebar-topics": "^0.7.1",
+ "starlight-sidebar-topics": "catalog:",

Based on learnings: Use pnpm for package management; leverage workspaces with catalog for dependency versioning.

Also applies to: 36-36, 45-46

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@docs/ensnode.io/package.json` around lines 19 - 23, The package.json has
hardcoded Astro-related versions for "@astrojs/mdx", "@astrojs/sitemap",
"@astrojs/starlight", "@astrojs/starlight-tailwind" (and currently an odd
"@astrojs/react": "catalog:"); replace these explicit version strings with
workspace catalog references (e.g. "catalog:" notation) and add the
corresponding version entries into the workspace catalog (pnpm's packageCatalog
/ workspace package manifests) so all Astro-adjacent deps are centrally
versioned; update the package.json lines for "@astrojs/mdx", "@astrojs/sitemap",
"@astrojs/starlight", "@astrojs/starlight-tailwind" and ensure the workspace
catalog contains matching keys for those package names (and fix the
"@astrojs/react" entry to use the correct catalog key) to avoid version drift
across docs packages.

"@astrojs/tailwind": "catalog:",
Comment on lines 20 to 24
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With astro@6 (and Vite 7) in the lockfile, keeping @astrojs/react and @astrojs/tailwind on the catalog-pinned versions appears incompatible: @vitejs/plugin-react@4.7.0 peers on vite@^6.4.2 (but Astro 6 uses Vite 7), and @astrojs/tailwind@6.0.2 peers on astro up to v5 and tailwindcss@^3.0.24 (but this package uses Tailwind 4). Bump @astrojs/react / @astrojs/tailwind to versions that support Astro 6 + Vite 7 + Tailwind 4 (and update the workspace catalog accordingly), otherwise installs/builds will have broken peer dependency resolution.

Copilot uses AI. Check for mistakes.
"@fontsource/inter": "^5.2.5",
"@fontsource/inter": "^5.2.8",
"@headlessui-float/react": "0.15.1",
"@headlessui/react": "^2.2.0",
"@iconify-json/lucide": "^1.2.52",
Expand All @@ -33,7 +33,7 @@
"astro": "catalog:",
"astro-font": "catalog:",
"astro-icon": "^1.1.5",
"astro-mermaid": "^1.0.4",
"astro-mermaid": "^2.0.1",
"astro-seo": "catalog:",
"classcat": "5.0.5",
"fuse.js": "^7.1.0",
Expand All @@ -42,8 +42,8 @@
"react-dom": "^18",
"react-wrap-balancer": "^1.1.1",
"sharp": "^0.33.5",
"starlight-llms-txt": "^0.5.0",
"starlight-sidebar-topics": "^0.4.1",
"starlight-llms-txt": "^0.8.1",
"starlight-sidebar-topics": "^0.7.1",
"tailwindcss": "4.1.5"
},
"devDependencies": {
Expand Down
Loading
Loading