Upgrade astro and its related dependencies for ENSNode Docs website#1979
Upgrade astro and its related dependencies for ENSNode Docs website#1979
astro and its related dependencies for ENSNode Docs website#1979Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
📝 WalkthroughWalkthroughUpdated dependency versions across workspace configuration files. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/ensnode.io/package.json`:
- Around line 19-23: The package.json has hardcoded Astro-related versions for
"@astrojs/mdx", "@astrojs/sitemap", "@astrojs/starlight",
"@astrojs/starlight-tailwind" (and currently an odd "@astrojs/react":
"catalog:"); replace these explicit version strings with workspace catalog
references (e.g. "catalog:" notation) and add the corresponding version entries
into the workspace catalog (pnpm's packageCatalog / workspace package manifests)
so all Astro-adjacent deps are centrally versioned; update the package.json
lines for "@astrojs/mdx", "@astrojs/sitemap", "@astrojs/starlight",
"@astrojs/starlight-tailwind" and ensure the workspace catalog contains matching
keys for those package names (and fix the "@astrojs/react" entry to use the
correct catalog key) to avoid version drift across docs packages.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: c3dc7879-3fd0-473f-b5ab-9fc83fea505f
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
docs/ensnode.io/package.jsonpnpm-workspace.yaml
| "@astrojs/mdx": "^5.0.3", | ||
| "@astrojs/react": "catalog:", | ||
| "@astrojs/sitemap": "^3.6.0", | ||
| "@astrojs/starlight": "^0.36.1", | ||
| "@astrojs/starlight-tailwind": "^4.0.1", | ||
| "@astrojs/sitemap": "^3.7.2", | ||
| "@astrojs/starlight": "^0.38.3", | ||
| "@astrojs/starlight-tailwind": "^5.0.0", |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider moving these Astro ecosystem versions into the workspace catalog.
Keeping Astro-adjacent versions centralized reduces drift across docs packages during future framework upgrades.
📦 Suggested catalog refactor
# pnpm-workspace.yaml
catalog:
+ "@astrojs/mdx": ^5.0.3
+ "@astrojs/sitemap": ^3.7.2
+ "@astrojs/starlight": ^0.38.3
+ "@astrojs/starlight-tailwind": ^5.0.0
+ "astro-mermaid": ^2.0.1
+ "starlight-llms-txt": ^0.8.1
+ "starlight-sidebar-topics": ^0.7.1
# docs/ensnode.io/package.json
- "@astrojs/mdx": "^5.0.3",
+ "@astrojs/mdx": "catalog:",
- "@astrojs/sitemap": "^3.7.2",
+ "@astrojs/sitemap": "catalog:",
- "@astrojs/starlight": "^0.38.3",
+ "@astrojs/starlight": "catalog:",
- "@astrojs/starlight-tailwind": "^5.0.0",
+ "@astrojs/starlight-tailwind": "catalog:",
- "astro-mermaid": "^2.0.1",
+ "astro-mermaid": "catalog:",
- "starlight-llms-txt": "^0.8.1",
+ "starlight-llms-txt": "catalog:",
- "starlight-sidebar-topics": "^0.7.1",
+ "starlight-sidebar-topics": "catalog:",Based on learnings: Use pnpm for package management; leverage workspaces with catalog for dependency versioning.
Also applies to: 36-36, 45-46
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/ensnode.io/package.json` around lines 19 - 23, The package.json has
hardcoded Astro-related versions for "@astrojs/mdx", "@astrojs/sitemap",
"@astrojs/starlight", "@astrojs/starlight-tailwind" (and currently an odd
"@astrojs/react": "catalog:"); replace these explicit version strings with
workspace catalog references (e.g. "catalog:" notation) and add the
corresponding version entries into the workspace catalog (pnpm's packageCatalog
/ workspace package manifests) so all Astro-adjacent deps are centrally
versioned; update the package.json lines for "@astrojs/mdx", "@astrojs/sitemap",
"@astrojs/starlight", "@astrojs/starlight-tailwind" and ensure the workspace
catalog contains matching keys for those package names (and fix the
"@astrojs/react" entry to use the correct catalog key) to avoid version drift
across docs packages.
There was a problem hiding this comment.
Pull request overview
Upgrades the ENSNode docs website (Astro/Starlight-based) to Astro v6 to address a security audit finding, updating related dependencies and refreshing the pnpm lockfile accordingly.
Changes:
- Bump workspace
astrocatalog version from^5.18.1to^6.1.8. - Update
docs/ensnode.ioAstro ecosystem dependencies (MDX, Starlight, sitemap, mermaid, etc.) to versions compatible with Astro 6. - Regenerate
pnpm-lock.yamlto reflect the new dependency graph.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates the workspace catalog astro version to v6. |
| docs/ensnode.io/package.json | Bumps docs-site Astro/Starlight-related dependencies to newer versions. |
| pnpm-lock.yaml | Lockfile update reflecting Astro 6 + dependency upgrades. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@types/react": 19.2.7 | ||
| "@types/react-dom": 19.2.3 | ||
| astro: ^5.18.1 | ||
| astro: ^6.1.8 | ||
| astro-font: ^1.1.0 | ||
| astro-seo: ^0.8.4 |
There was a problem hiding this comment.
astro was bumped to v6 in the workspace catalog, but the catalog still pins @astrojs/react to v4 and @astrojs/tailwind to v6. The lockfile shows @astrojs/tailwind@6.0.2 only supports astro up to v5 and tailwindcss v3, and @vitejs/plugin-react@4.7.0 peers on vite@^6.4.2 while Astro 6 pulls in Vite 7. This is likely to produce peer dependency conflicts and may break the docs build; update the catalog to @astrojs/* versions that declare compatibility with Astro 6 (and Vite 7 / Tailwind 4), or adjust the Astro/Vite versions to match the currently pinned integrations.
| "@astrojs/react": "catalog:", | ||
| "@astrojs/sitemap": "^3.6.0", | ||
| "@astrojs/starlight": "^0.36.1", | ||
| "@astrojs/starlight-tailwind": "^4.0.1", | ||
| "@astrojs/sitemap": "^3.7.2", | ||
| "@astrojs/starlight": "^0.38.3", | ||
| "@astrojs/starlight-tailwind": "^5.0.0", | ||
| "@astrojs/tailwind": "catalog:", |
There was a problem hiding this comment.
With astro@6 (and Vite 7) in the lockfile, keeping @astrojs/react and @astrojs/tailwind on the catalog-pinned versions appears incompatible: @vitejs/plugin-react@4.7.0 peers on vite@^6.4.2 (but Astro 6 uses Vite 7), and @astrojs/tailwind@6.0.2 peers on astro up to v5 and tailwindcss@^3.0.24 (but this package uses Tailwind 4). Bump @astrojs/react / @astrojs/tailwind to versions that support Astro 6 + Vite 7 + Tailwind 4 (and update the workspace catalog accordingly), otherwise installs/builds will have broken peer dependency resolution.
Lite PR
Tip: Review docs on the ENSNode PR process
Summary
astro@6dependency. Also, had to upgrade other dependencies to make the migration fromastro@5toastro@6to work.Why
astro@5toastro@6.Testing
Notes for Reviewer (Optional)
Pre-Review Checklist (Blocking)