fix(browser): guard unresolved context before persistent state and artifacts - #50
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up the already merged #48 browser-routing API without replacing its per-call MCP account/host support or browserContext/browse.context contracts.
Independent review found three remaining boundaries: an inherited host was treated as local for artifacts; incomplete identities could reuse shared cache/approval/journal state; and install/enable commands could mutate settings before rejecting unknown arguments. This patch requires explicit local host for local materialization, disables reusable state for incomplete contexts, validates administrative modes before side effects, and rejects flag-shaped/control-character host values.
Validation: 1,097 passed, 0 failed, 1 platform skip in the combined suite; 78 focused tests; structure/syntax/machine-identity guards passed. Independent adaptation reviewer passed with 11 focused tests. Existing persistence tests keep their assertions and now supply explicit identities. No dependencies, version bump, release or global Aside defaults change.
Supersedes only the additional hardening portion of closed #47; #48 remains the canonical routing implementation. Targets dev as requested.