Repository navigation
feat(dependency-proxy): Endpoint for org and instanceAdmin for cache stats - #3171
Open
juliankepka wants to merge 4 commits into
Open
juliankepka wants to merge 4 commits into
juliankepka wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each organization gets its own subdirectory, named after its org ID, which prevents cache poisoning across organizations.
DEPENDENCY_PROXY_CACHE_MAX_SIZE_MB now applies per organization. On startup, leftover files from the old flat cache layout are removed, and each org directory is cleared the first time it is used after a restart, so the in-memory index and the disk stay consistent.
The cache now tracks size, number of entries, hits, misses and evictions, exposed through
GET
/organizations/{organization}/dependency-proxy/cache-stats/for org admins andGET
/admin/statistics/dependency-proxy-cache/for instance admins (aggregated across all organizations).This PR depends on the PR #3162 that removes the unauthenticated proxy routes: requests without a secret have no organization and currently return 500.