Skip to content

Propagate toolchain to custom GLFW build#7383

Open
mprat wants to merge 1 commit into
isl-org:mainfrom
mprat:patch-1
Open

Propagate toolchain to custom GLFW build#7383
mprat wants to merge 1 commit into
isl-org:mainfrom
mprat:patch-1

Conversation

@mprat

@mprat mprat commented Dec 9, 2025

Copy link
Copy Markdown

When cross-compiling or building with a custom toolchain for headless rendering, a custom GLFW build is required. However, the toolchain is not automatically passed into the external project that passes cmake arguments to the GLFW build.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

When cross-compiling or building with a custom toolchain for headless rendering, a custom GLFW build is required. However, the toolchain is not automatically passed into the external project that passes cmake arguments to the GLFW build.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

@update-docs

update-docs Bot commented Dec 9, 2025

Copy link
Copy Markdown

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@mprat mprat marked this pull request as ready for review December 10, 2025 01:20

@ssheorey ssheorey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mprat this change would be needed for all dependencies, not just glfw, right? In that case can you add this to the macro:

ExternalProject_CMAKE_ARGS

in find_dependencies.cmake?

@ssheorey ssheorey added the status / needs info Waiting for information from reporter / author label Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status / needs info Waiting for information from reporter / author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants