chore(cd): clear the placeholder npm token so trusted publishing works - #536
Merged
Conversation
The publish step reached the registry, signed provenance, and then failed with E404 on the PUT. That E404 is npm masking an authorization failure. `setup-node` exports NODE_AUTH_TOKEN as the literal placeholder XXXXX-XXXXX-XXXXX-XXXXX when no token input is given, and the .npmrc it writes points `_authToken` at that variable. npm therefore sent the placeholder as a real credential and never attempted the OIDC exchange, which is why the log has no trusted-publishing activity at all. Reproduced locally against the same .npmrc shape: NODE_AUTH_TOKEN=XXXXX-XXXXX-XXXXX-XXXXX -> E401 Unauthorized NODE_AUTH_TOKEN='' -> ENEEDAUTH, no credential configured The second state is what lets npm fall back to trusted publishing, so the publish step now clears the variable. This requires a trusted publisher to be configured on npmjs.com for both @ionic/angular-toolkit and @ionic/cordova-builders. Without that, the publish fails on auth regardless of this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the
13.0.0publish