fix(cd): publish 13.0.0, and stop reporting success when nothing publishes - #537
Merged
Conversation
The publish now fails with a bare ENEEDAUTH. npm's OIDC helper logs every failure path
at verbose, so at the default loglevel there is no way to tell a missing trusted
publisher from a permissions problem or a bad id_token:
log.verbose('oidc', `Failed token exchange request with body message: ...`)
log.verbose('oidc', 'Failed because token exchange was missing the token in the body')
log.silly('oidc', 'Skipped because incorrect permissions for id-token ...')
Raising the loglevel makes the next run state the reason instead of us inferring it.
Re-running an old CD run went green having shipped nothing. A workflow re-run checks out the run's original commit, where the manifests still carried the pre-release versions, so `lerna version` declined with an EBEHIND warning and exited 0, and every package then looked already published and was skipped. The publish script now exits non-zero when it publishes no packages, so that state fails loudly instead of reporting success.
ShaneK
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish v13