(MOT-4660) perf(editor,database,computer,document,email,github,security-scan): trim function contract prose - #1065
Merged
Conversation
…ty-scan): trim function contract prose Same rule as MOT-4639 / MOT-4654 / MOT-4655 / MOT-4656 / MOT-4658, applied to the medium batch of workers the survey flagged: function description <= ~300 chars (what it does + the one non-obvious calling rule), request property one sentence <= ~140, internal notes moved from `///` to `//`, no type, field, or serde change. email::send 632 -> 235 editor SaveInput.expected_version 479 -> 137 email::search 416 -> 284 editor SaveInput.expected_mtime 458 -> 139 document ocr 346 -> 232 database QueryReq.record_history 420 -> 48 computer sessions::start 333 -> 252 computer StartInput.endpoint 359 -> 127 github api 330 -> 232 computer StartInput.image 337 -> 115 editor::changes 325 -> 210 database SchemaDiagramReq.focus 302 -> 63 security-scan::request 324 -> 219 document ocr Request.pages 272 -> 129 17 goldens regenerated (description lines only). Response-only types (editor Buffer, document Body/Asset/DetectedFrom) and config structs left as they were, per scope. Claude-Session: https://claude.ai/code/session_01EUoLR66baA2QL7x6fH72bT
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 28 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (37)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
skill-check — worker0 verified, 70 skipped (no docs/).
Four for four. Nicely done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes MOT-4660. Sub-issue of MOT-4636; same rule as #1056, #1058, #1060, #1061, #1063, applied to the medium batch of workers the survey flagged.
Change (editorial, at the source)
Function description ≤ ~300 chars (what it does + the one non-obvious calling rule); request property one sentence ≤ ~140; internal notes moved from
///to//; no type, field, or serde change. Response-only types (editorBuffer, documentBody/Asset/DetectedFrom) and config structs untouched, per scope.email::sendemail::searchSaveInput.expected_version/.expected_mtimeeditor::changesFindInput.include_untracked,GitHunksInput.context_lines,Against::Upstream, …QueryReq.record_history(serde-skipped, never in schema)SchemaDiagramReq.focus,FilterOp::In,FilterSpec.disabled,ExecuteBatchReq.statements,RowChangedConfig.db, …sessions::startStartInput.endpoint/.image/.os/.monitorocr/markdowndescriptionsocr::Request.pages,DocumentSource.file_name/.fs_scope,FsScopeapi/execdescriptions,ApiRequest.pathsecurity-scan::requestNo enum conversions:
StartInput.osinherits a free-text configured value for remote sessions (not a closed set);isolationis validated at runtime and already under the limit.Gates
All seven crates:
cargo fmt,cargo clippy --all-features --all-targets -D warnings,cargo testgreen (editor 178, database 386, computer 32, document 89, email 14, github 55, security-scan 108). 17 goldens regenerated withUPDATE_GOLDENS=1, description lines only. database'stests/e2e/is a TypeScript/docker harness outsidecargo testand was not run.https://claude.ai/code/session_01EUoLR66baA2QL7x6fH72bT