(MOT-4661) perf(pdf,canvas,a2ui,tailscale,bridge,pubsub,web,worktree,provider-llamacpp): trim request docs over 140 chars - #1067
Merged
Conversation
…provider-llamacpp): trim request docs over 140 chars Long tail of the prose survey (MOT-4639 / MOT-4654 / MOT-4655 / MOT-4656 / MOT-4658 / MOT-4659 / MOT-4660): no function description in these crates was over 300 chars; 14 request property docs were over 140 and are now one sentence each. Internal notes moved from `///` to `//`; no type, field, or serde change; 11 goldens regenerated (description lines only). pdf PdfSource.fs_scope 193 -> 113 canvas validate.format 182 -> 135 web FetchPayload.format 177 -> 92 a2ui Component.properties 177 -> 127 provider-llamacpp CountTokensRequest.model 175 -> 113 worktree create.Request.pr 179 -> 127 tailscale ServeAddInput.target 155 -> 139 memory, approval-gate and rbac-proxy had only response/config/internal docs over the limit and are untouched. Claude-Session: https://claude.ai/code/session_01EUoLR66baA2QL7x6fH72bT
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (25)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
skill-check — worker0 verified, 70 skipped (no docs/).
Four for four. Nicely done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes MOT-4661. Sub-issue of MOT-4636; the long tail of the prose survey after #1056, #1058, #1060, #1061, #1063, #1065, #1066.
Change
No function description in these crates was over 300 chars; 14 request property docs were over 140 and are now one sentence each. Internal notes moved from
///to//. No type, field, or serde change. 11 goldens regenerated withUPDATE_GOLDENS=1, description lines only.PdfSource.fs_scope(flattened into all 5 requests)items::Request.max_items/markdown::Request.pages/classify::Request.sample_pagescreate::Request.prsyntax::Request.family/validate::Request.formatComponent.propertiesInvokeInput.timeout_msSubscribeTriggerSpec.condition_function_idServeAddInput.targetFetchPayload.formatPageFormatis a schema enum)CountTokensRequest.model/EmbedRequest.modelmemory, approval-gate and rbac-proxy were on the survey list but only had response, config or internal docs over the limit (
Memory.tags,PendingKind,RbacConfig), so they are untouched.Gates
All nine touched crates:
cargo fmt,cargo clippy --all-features --all-targets -D warningsgreen;cargo testgreen for pdf (103), canvas (78), a2ui (38), tailscale (34), bridge (37), pubsub (30), web (105). worktree and provider-llamacpp: every target green excepttests/integration.rs, which spawns a localiiiengine and fails identically on an untouchedmaincheckout on this machine ("engine did not become ready in 15s"); CI runs them with its own engine.https://claude.ai/code/session_01EUoLR66baA2QL7x6fH72bT