Skip to content

fix(metrics): map connection_id to webhook_id for --dimensions #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leggetter merged 1 commit into from
Feb 27, 2026
Merged

fix(metrics): map connection_id to webhook_id for --dimensions #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/cmd/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func addMetricsCommonFlagsEx(cmd *cobra.Command, f *metricsCommonFlags, skipIssu
cmd.Flags().StringVar(&f.end, "end", "", "End of time range (ISO 8601 date-time, required)")
cmd.Flags().StringVar(&f.granularity, "granularity", "", granularityHelp)
cmd.Flags().StringVar(&f.measures, "measures", "", "Comma-separated list of measures to return")
cmd.Flags().StringVar(&f.dimensions, "dimensions", "", "Comma-separated list of dimensions")
cmd.Flags().StringVar(&f.dimensions, "dimensions", "", "Comma-separated dimensions to group by (e.g. connection_id, source_id, destination_id, status)")
cmd.Flags().StringVar(&f.sourceID, "source-id", "", "Filter by source ID")
cmd.Flags().StringVar(&f.destinationID, "destination-id", "", "Filter by destination ID")
cmd.Flags().StringVar(&f.connectionID, "connection-id", "", "Filter by connection ID")
Expand All @@ -106,6 +106,10 @@ func metricsParamsFromFlags(f *metricsCommonFlags) hookdeck.MetricsQueryParams {
if f.dimensions != "" {
for _, s := range strings.Split(f.dimensions, ",") {
if t := strings.TrimSpace(s); t != "" {
// API expects webhook_id for connection dimension; CLI accepts connection_id/connection-id for consistency.
if t == "connection_id" || t == "connection-id" {
t = "webhook_id"
}
dimensions = append(dimensions, t)
}
}
Expand Down