fix(metrics): map connection_id to webhook_id for --dimensions#224
Merged
fix(metrics): map connection_id to webhook_id for --dimensions#224
Conversation
…ensions The API expects dimension name webhook_id (historical); agents and users often pass connection_id. Map connection_id and connection-id to webhook_id so 'hookdeck gateway metrics events ... --dimensions connection_id' works without 422. Also improve --dimensions help with example dimensions. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The API expects dimension name
webhook_id(historical); agents and users often passconnection_id. This caused 422 when using--dimensions connection_id.Changes
metricsParamsFromFlags, mapconnection_idandconnection-idtowebhook_idbefore appending to dimensions sohookdeck gateway metrics events ... --dimensions connection_idworks without 422.--dimensionshelp with example dimensions (connection_id, source_id, destination_id, status).Testing
go test ./pkg/...passes.Made with Cursor