feat(o11y): remove google-cloud-unstable-tracing guards and regenerate#5292
Merged
haphungw merged 6 commits intogoogleapis:mainfrom Apr 13, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5292 +/- ##
==========================================
- Coverage 97.58% 97.56% -0.03%
==========================================
Files 222 222
Lines 46609 46616 +7
==========================================
- Hits 45485 45481 -4
- Misses 1124 1135 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
from
c86588b to
aaabb6e
Compare
This was referenced Apr 5, 2026
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
from
a1c2fd5 to
60b498d
Compare
haphungw
changed the title
google-cloud-unstable-tracing guards and regenerate
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
4 times, most recently
from
134dd05 to
98362b5
Compare
haphungw
added a commit
that referenced
this pull request
Apr 7, 2026
Restore the test to use `#[tokio::test(flavor = "multi_thread", worker_threads = 2)]` so the background server can run on a separate thread. I made a mistake when applying `#[tokio::test(flavor = "current_thread", start_paused = true)]` to `grpc_client_request_success`. This failed because: 1. This test does not contain any sleeps to optimize. 2. It starts a background gRPC server, which deadlocks on a single thread when the client waits for a response. This surfaces in #5292 when the `unstable_tracing` guards are removed.
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
3 times, most recently
from
706eb09 to
8accedb
Compare
haphungw
added a commit
that referenced
this pull request
Apr 7, 2026
Add missing feature guards within `gax-internal` for isolation between HTTP and gRPC transport layers. Essentially fix build error for #5292.
haphungw
added a commit
that referenced
this pull request
Apr 7, 2026
Fix a `gcb-pr-minimal-versions` build failure in `google-cloud-gax-internal` tests caused by `h2` version `0.4.2`, which surfaces after `google_cloud_unstable_tracing` guards are removed in #5292. The Problem During minimal-versions checks, `h2` resolves to `0.4.2`, which somehow leads to deadlocks or missing tracing spans in our gRPC tests. Previous Attempts I tried switching tests to `multi_thread` (PR #5308), which masked the issue but was not a good solution. I tried forcing the version in the root `[workspace.dependencies]`, but `Cargo` ignored it during the isolated package build for `gax-internal`. The Fix Add `h2 = "0.4.13"` as a direct dependency in `src/gax-internal/Cargo.toml`. `0.4.13` is the version resolved in our normal Cargo.lock.
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
2 times, most recently
from
2ad970b to
f368b85
Compare
haphungw
changed the title
google-cloud-unstable-tracing guards and regenerategoogle-cloud-unstable-tracing guards and regenerate
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
from
f368b85 to
c80a9d7
Compare
haphungw
added a commit
to googleapis/librarian
that referenced
this pull request
Apr 13, 2026
…5103) Remove `google_cloud_unstable_tracing` conditional compilation guards from the Rust templates. This makes tracing unconditionally available in the generated code, subject to runtime configuration via `gaxi::options::tracing_enabled`. This change prepares for the removal of the unstable feature flag in `google-cloud-rust`: [google-cloud-rust/pull/5292](googleapis/google-cloud-rust#5292)
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
2 times, most recently
from
307790b to
acbf08c
Compare
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
from
acbf08c to
307790b
Compare
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
from
307790b to
f6a03af
Compare
coryan
reviewed
Apr 13, 2026
Contributor
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
I am missing some large portions of the old code, help?
coryan
approved these changes
Apr 13, 2026
coryan
approved these changes
Apr 13, 2026
haphungw
added a commit
to googleapis/librarian
that referenced
this pull request
Apr 13, 2026
Remove the redundant braces from the `tracing.rs.mustache` template googleapis/google-cloud-rust#5292, left behind during the removal of `google_cloud_unstable_tracing` guards in #5103.
haphungw
added a commit
that referenced
this pull request
Apr 14, 2026
Add a new integration test `grpc_transport_observability.rs` to verify that transport-level metrics, spans, and logs are correctly emitted. The test uses an in-memory collector to verify: - `gcp.client.attempt.duration` metric is recorded. - Transport span is created with `Error` status on failure. - Actionable error log is emitted with correct trace correlation. This test aims at increase coverage for transport-level signals, which were missed @ commit [f6a03af](#5292 (comment))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.