feat(o11y): remove google-cloud-unstable-tracing guards#5382
Closed
haphungw wants to merge 1 commit intogoogleapis:mainfrom
Closed
feat(o11y): remove google-cloud-unstable-tracing guards#5382haphungw wants to merge 1 commit intogoogleapis:mainfrom
google-cloud-unstable-tracing guards#5382haphungw wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5382 +/- ##
==========================================
+ Coverage 97.59% 97.76% +0.17%
==========================================
Files 222 222
Lines 46609 46599 -10
==========================================
+ Hits 45486 45556 +70
+ Misses 1123 1043 -80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This approach couldn't solve the circular dependency problem. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
google_cloud_unstable_tracingfeature guards from handwritten code (src/gax-internal/,src/storage/, andtests), making observability features unconditionally available.This PR is the first step in resolving a cross-repository dependency involving the code generator (
librarian/sidekick) googleapis/librarian#5343:Since we updated the generator to produce code without guards before removing the guards manually in
gax-internal, the resulting generated code failed compilation checks because it attempted to use features that are still feature-gated in the library.Correct Steps:
Manual removal in Rust (This PR).
Librarian change to remove guard generation googleapis/librarian#5103.
Regeneration PR in Rust #5292.
Note: We also kept
cfg(google_cloud_unstable_tracing)in Cargo.toml for now, so that the existing generated code still in the repo doesn't fail theunexpected_cfgslint. This should be removed in the regeneration PR forgoogle-cloud-rust.Fixes googleapis/librarian#5343