Repository navigation
[C#] Fix incorrect offset type in verifier (#8937) - #8975
Open
LacoVadkerti wants to merge 2 commits into
Open
LacoVadkerti wants to merge 2 commits into
LacoVadkerti wants to merge 2 commits into
Conversation
LacoVadkerti
commented
Mar 12, 2026
LacoVadkerti
commented
- Fixed incorrect offset type in generic C# verifier code
- Extended a unit test for detecting the issue
- Updated C# test execution scripts
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
Can someone please review this fix. The bug is real and the fix seems to be correct. |
This was referenced Oct 28, 2026
Contributor
|
Could you please look at these PRs that want to fix the same Bug in GetVRelOffset in FlatBufferVerify.cs: Thanks |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.