Skip to content

[C#] Incorrect offset type in verifier #8937

Open

Description

@LacoVadkerti

Offset type is converted to int16, but is computed as int position - int offset:

short vtable = Convert.ToInt16(pos - ReadSOffsetT(verifier_buffer, pos));

Activity

  1. jtdavis777 commented on Mar 5, 2026

    @jtdavis777
    Collaborator

    Hey @LacoVadkerti - would you be up for putting up a PR to fix this? maybe a test to show the problem as well?

  2. LacoVadkerti commented on Mar 6, 2026

    @LacoVadkerti
    Author

    Hi @jtdavis777, OK, just give me some time to check how to do it.

  3. tmimmanuel commented on Mar 12, 2026

    @tmimmanuel
    Contributor

    Hello, @jtdavis777 @LacoVadkerti
    Is that okay that I raise a PR to solve this issue?

  4. LacoVadkerti commented on Mar 12, 2026

    @LacoVadkerti
    Author

    Hi @tmimmanuel, @jtdavis777, I just finished my PR: #8975, but I'm not sure if it is created properly as it is not connected to this issue and I'm also not able to add you as reviewers.

  5. jtdavis777 commented on Mar 12, 2026

    @jtdavis777
    Collaborator

    got you linked up! you can put fixes #<issue number> in future PRs to link them

  6. github-actions commented on Sep 10, 2026

    @github-actions
    Contributor

    This issue is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

  7. stefan301 commented on Sep 11, 2026

    @stefan301
    Contributor

    not-stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions