fix: match popup animation params to GNOME 51

packages/gnome-shell/src/ui/appDisplay.d.ts

@@ -117,7 +117,13 @@ export abstract class BaseAppView extends St.Widget {
 
     _onDestroy(): void;
     _createGrid(): AppGrid;
-    _onScroll(actor: St.ScrollView, event: Clutter.ScrollEvent): boolean;
+    /**
+     * Handles the `scroll` signal of the page's scroll controller. GNOME 51
+     * replaced the old `(actor, event)` handler with these arguments.
+     *
+     * @version 51
+     */
+    _onScroll(controller: Clutter.ScrollController, sprite: Clutter.Sprite, source: Clutter.ScrollSource, dx: number, dy: number): void;
     _swipeBegin(tracker: any, monitor: Clutter.EventSequence): void;
     _swipeUpdate(tracker: any, progress: number): void;
     _swipeEnd(tracker: any, duration: number, endProgress: number): void;
@@ -226,8 +232,13 @@ export class AppDisplay extends BaseAppView {
     _getItemPosition(item: AppViewItem): [number, number];
     _compareItems(a: AppViewItem, b: AppViewItem): number;
     _loadApps(): AppViewItem[];
-    _onScroll(actor: St.ScrollView, event: Clutter.ScrollEvent): boolean;
-    _onKeyPressEvent(actor: St.Widget, event: Clutter.KeyEvent): boolean;
+    /**
+     * Handles the `scroll` signal of the page's scroll controller. GNOME 51
+     * replaced the old `(actor, event)` handler with these arguments.
+     *
+     * @version 51
+     */
+    _onScroll(controller: Clutter.ScrollController, sprite: Clutter.Sprite, source: Clutter.ScrollSource, dx: number, dy: number): void;
     _maybeMoveItem(dragEvent: DragEvent): void;
     /** @hidden */
     _onDragBegin(): void;

packages/gnome-shell/src/ui/appFavorites.d.ts

@@ -9,7 +9,6 @@ declare class AppFavorites extends EventEmitter {
 
     constructor();
 
-    _onFavsChanged(): void;
     _getIds(): string[];
     _addFavorite(appId: string, pos: number): void;
     _removeFavorite(appId: string): void;

packages/gnome-shell/src/ui/boxpointer.d.ts

@@ -27,8 +27,8 @@ export class BoxPointer extends St.Widget {
     _border: St.DrawingArea;
     _arrowAlignment: number;
     _sourceAlignment: number;
-    _muteKeys: boolean;
-    _muteInput: boolean;
+    _muteKeys: Clutter.KeyController;
+    _muteInput: Clutter.ClickGesture;
     _sourceActor: Clutter.Actor | null;
     _sourceExtents: ReturnType<typeof Clutter.Actor.prototype.get_transformed_extents>;
     _workArea: ReturnType<typeof LayoutManager.prototype.getWorkAreaForMonitor>;
@@ -51,8 +51,6 @@ export class BoxPointer extends St.Widget {
      */
     _init(arrowSide: St.Side, binProperties?: Partial<St.Bin.ConstructorProps>): void;
 
-    vfunc_captured_event(event: Clutter.Event): boolean;
-
     vfunc_get_preferred_width(forHeight: number): [number, number];
 
     vfunc_get_preferred_height(forWidth: number): [number, number];

packages/gnome-shell/src/ui/calendar.d.ts

@@ -5,7 +5,6 @@ import type Gio from '@girs/gio-2.0';
 import type St from '@girs/st-51';
 import type Clutter from '@girs/clutter-51';
 
-import type { Switch } from './popupMenu.js';
 import type { MessageView } from './messageList.js';
 
 declare function sameYear(dateA: Date, dateB: Date): boolean;
@@ -154,7 +153,13 @@ export class Calendar extends St.Widget {
 
     updateTimeZone(): void;
 
-    vfunc_scroll_event(event: Clutter.ScrollEvent): boolean;
+    /**
+     * Handles the `scroll` signal of the calendar's scroll controller, which
+     * flips to the previous or next month.
+     *
+     * @version 51
+     */
+    _onScroll(controller: Clutter.ScrollController, sprite: Clutter.Sprite, source: Clutter.ScrollSource, dx: number, dy: number): void;
 
     _buildHeader(): void;
     _onPrevMonthButtonClicked(): void;
@@ -174,17 +179,6 @@ declare class Placeholder extends St.BoxLayout {
     _init(): void;
 }
 
-declare class DoNotDisturbSwitch extends Switch {
-    _settings: Gio.Settings;
-
-    constructor();
-    /** @hidden */
-    override _init(config?: Partial<St.Bin.ConstructorProps>): void;
-    /** @hidden */
-    override _init(state: boolean): void;
-    _init(): void;
-}
-
 /**
  * @see https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/ui/calendar.js#L799
  * @version 48
@@ -193,8 +187,6 @@ declare class DoNotDisturbSwitch extends Switch {
 export class CalendarMessageList extends St.Widget {
     _placeholder: Placeholder;
     _scrollView: St.ScrollView;
-    _dndSwitch: DoNotDisturbSwitch;
-    _dndButton: St.Button;
     _clearButton: St.Button;
     _messageView: MessageView;
 

packages/gnome-shell/src/ui/dialog.d.ts

@@ -30,7 +30,6 @@ export class Dialog extends St.Widget {
 
     _init(parentActor: St.Widget, styleClass?: string | null): void;
     makeInactive(): void;
-    vfunc_event(event: Clutter.Event): boolean;
     addButton(buttonInfo: ButtonInfo): St.Button;
     clearButtons(): void;
 

packages/gnome-shell/src/ui/layout.d.ts

@@ -112,7 +112,6 @@ declare class ScreenTransition extends Clutter.Actor {
  * @version 48
  */
 declare class HotCorner extends Clutter.Actor {
-    _entered: boolean;
     _monitor: Monitor;
     _x: number;
     _y: number;
@@ -126,13 +125,9 @@ declare class HotCorner extends Clutter.Actor {
 
     setBarrierSize(size: number): void;
     handleDragOver(source: any, actor: any, x: number, y: number, time: number): DragMotionResult;
-    vfunc_leave_event(event: Clutter.Event): boolean;
 
-    _setupFallbackCornerIfNeeded(layoutManager: LayoutManager): void;
     _onDestroy(): void;
     _toggleOverview(): void;
-    _onCornerEntered(): void;
-    _onCornerLeft(actor: Clutter.Actor, event: Clutter.Event): void;
 }
 
 /**
@@ -159,7 +154,6 @@ export class LayoutManager extends GObject.Object {
     _keyboardHeightNotifyId: number;
     _backgroundGroup: Meta.BackgroundGroup;
     _interfaceSettings: Gio.Settings;
-    _pendingLoadBackground: boolean;
     _systemBackground: SystemBackground;
 
     readonly _startingUp: boolean;

packages/gnome-shell/src/ui/messageList.d.ts

@@ -19,10 +19,21 @@ export class URLHighlighter extends St.Label {
     _init(params?: Partial<St.Label.ConstructorProps>): void;
     _init(text?: string, lineWrap?: boolean, allowMarkup?: boolean): void;
 
-    vfunc_button_press_event(buttonEvent: Clutter.ButtonEvent): boolean;
-    vfunc_button_release_event(buttonEvent: Clutter.ButtonEvent): boolean;
-    vfunc_motion_event(motionEvent: Clutter.MotionEvent): boolean;
-    vfunc_leave_event(crossingEvent: Clutter.CrossingEvent): boolean;
+    /**
+     * Handles the `motion` signal of the label's motion controller, which sets
+     * the pointer cursor over a URL.
+     *
+     * @version 51
+     */
+    _onMotion(controller: Clutter.MotionController, sprite: Clutter.Sprite, x: number, y: number): void;
+
+    /**
+     * Handles the `leave` signal of the same controller and restores the
+     * default cursor.
+     *
+     * @version 51
+     */
+    _onLeave(): void;
     setMarkup(text?: string, allowMarkup?: boolean): void;
 
     _highlightUrls(): void;
@@ -117,7 +128,13 @@ export class Message extends St.Button {
 
     canClose(): boolean;
 
-    vfunc_key_press_event(keyEvent: Clutter.KeyEvent): boolean;
+    /**
+     * Closes the message if its notification allows it. The BackSpace and
+     * Delete key bindings call this.
+     *
+     * @version 51
+     */
+    _closeIfAllowed(): void;
 }
 
 /**
@@ -133,16 +150,11 @@ export class NotificationMessage extends Message {
 
     vfunc_clicked(): void;
     canClose(): boolean;
-
-    _getIcon(): St.Icon;
-    _onUpdated(n: Notification, _clear?: boolean): void;
 }
 
 declare class MediaMessage extends Message {
     _player: MprisPlayer;
     _icon: St.Icon;
-    _secondaryBin: St.Bin;
-    _closeButton: St.Button;
     _prevButton: St.Button;
     _playPauseButton: St.Button;
     _nextButton: St.Button;

packages/gnome-shell/src/ui/messageTray.d.ts

@@ -340,13 +340,11 @@ export class MessageTray extends St.Widget {
     _onDragBegin(): void;
     _onDragEnd(): void;
 
-    _onNotificationKeyRelease(actor: St.Widget, event: Clutter.Event): boolean;
     _expireNotification(): void;
     _addSource(source: Source): void;
     _removeSource(source: Source): void;
     _onSourceEnableChanged(policy: NotificationPolicy, source: Source): void;
     _onNotificationRemoved(source: Source, notification: Notification): void;
-    _onNotificationShow(_source: Source, notification: Notification): void;
     _resetNotificationLeftTimeout(): void;
     _onNotificationHoverChanged(): void;
     _onStatusChanged(status: PresenceStatus): void;

packages/gnome-shell/src/ui/modalDialog.d.ts

@@ -80,7 +80,6 @@ export class ModalDialog extends St.Widget {
     _fadeOutDialog(timestamp: number): void;
 
     vfunc_key_press_event(event: Clutter.Event): boolean;
-    vfunc_captured_event(event: Clutter.Event): boolean;
 
     clearButtons(): void;
     setButtons(buttons: ButtonInfo[]): void;

packages/gnome-shell/src/ui/popupMenu.d.ts

@@ -141,9 +141,7 @@ export class Switch extends St.Widget {
     _startDragging(event: Clutter.Event): typeof Clutter.EVENT_PROPAGATE;
     override vfunc_motion_event(event: Clutter.Event): typeof Clutter.EVENT_PROPAGATE;
     override vfunc_button_release_event(event: Clutter.Event): typeof Clutter.EVENT_PROPAGATE;
-    _touchDragging(actor: Clutter.Actor, event: Clutter.Event): typeof Clutter.EVENT_PROPAGATE;
     _endDragging(): typeof Clutter.EVENT_PROPAGATE;
-    _motionEvent(actor: Clutter.Actor, event: Clutter.Event): typeof Clutter.EVENT_PROPAGATE;
 
     // General signal handler methods
     connect(sigName: string, callback: (...args: any[]) => void): number;
@@ -235,6 +233,8 @@ export namespace PopupMenuBase {
 
     // PopupMenuBase.addMenuItem explicitly checks for any of these specific types
     type MenuItemType = PopupMenuSection | PopupSubMenuMenuItem | PopupSeparatorMenuItem | PopupBaseMenuItem;
+
+    type AnimationParams = { animate?: boolean; fadeOnly?: boolean };
 }
 
 /**
@@ -256,8 +256,8 @@ export abstract class PopupMenuBase<S extends Signals.SignalMap<S> = PopupMenuBa
 
     constructor(sourceActor: Clutter.Actor, styleClass?: string);
 
-    abstract open(animate?: BoxPointer.PopupAnimation): void;
-    abstract close(animate?: BoxPointer.PopupAnimation): void;
+    abstract open(params?: PopupMenuBase.AnimationParams): void;
+    abstract close(params?: PopupMenuBase.AnimationParams): void;
 
     _getTopMenu(): PopupMenuBase<S>;
     _setParent(parent: PopupMenuBase<S> | null): void;
@@ -301,8 +301,8 @@ export class PopupMenu<S extends Signals.SignalMap<S> = PopupMenu.SignalMap> ext
     _onKeyPress(actor: Clutter.Actor, event: Clutter.Event): void;
     setArrowOrigin(origin: number): void;
     setSourceAlignment(alignment: number): void;
-    override open(animate?: BoxPointer.PopupAnimation): void;
-    override close(animate?: BoxPointer.PopupAnimation): void;
+    override open(params?: PopupMenuBase.AnimationParams): void;
+    override close(params?: PopupMenuBase.AnimationParams): void;
     override destroy(): void;
 }
 
@@ -346,8 +346,8 @@ export class PopupSubMenu<S extends Signals.SignalMap<S> = PopupSubMenu.SignalMa
     getSensitive(): boolean;
     // PopupSubMenu's methods technically use a boolean, but because PopupAnimation is just a number,
     // with PopupAnimation.NONE == 0, it can be used like a boolean, so at runtime it works.
-    override open(animate?: BoxPointer.PopupAnimation): void;
-    override close(animate?: BoxPointer.PopupAnimation): void;
+    override open(params?: PopupMenuBase.AnimationParams): void;
+    override close(params?: PopupMenuBase.AnimationParams): void;
     _onKeyPressEvent(actor: Clutter.Actor, event: Clutter.Event): typeof Clutter.EVENT_PROPAGATE;
 }
 

packages/gnome-shell/src/ui/quickSettings.d.ts

@@ -192,8 +192,8 @@ export class QuickToggleMenu extends PopupMenu.PopupMenuBase {
      */
     addHeaderSuffix(actor: Clutter.Actor): void;
 
-    override open(animate?: PopupAnimation): void;
-    override close(animate?: PopupAnimation): void;
+    override open(params?: PopupMenu.PopupMenuBase.AnimationParams): void;
+    override close(params?: PopupMenu.PopupMenuBase.AnimationParams): void;
 
     _syncChecked(): void;
 
@@ -313,8 +313,8 @@ export class QuickSettingsMenu extends PopupMenu.PopupMenu {
      */
     getFirstItem(): Clutter.Actor;
 
-    override open(animate?: PopupAnimation): void;
-    override close(animate?: PopupAnimation): void;
+    override open(params?: PopupMenu.PopupMenuBase.AnimationParams): void;
+    override close(params?: PopupMenu.PopupMenuBase.AnimationParams): void;
 
     _completeAddItem(item: Clutter.Actor, colSpan: number): void;
     _setDimmed(dim: boolean): void;

packages/gnome-shell/src/ui/search.d.ts

@@ -2,6 +2,7 @@
 
 import type St from '@girs/st-51';
 import type Clutter from '@girs/clutter-51';
+import type GObject from '@girs/gobject-2.0';
 
 import { AppSearchProvider } from './appDisplay.js';
 
@@ -16,6 +17,30 @@ export interface MetaInfo {
     clipboardText?: string;
 }
 
+export namespace SearchEntry {
+    export interface SignalSignatures extends St.Entry.SignalSignatures {
+        'activate-new-instance': () => void;
+    }
+}
+
+/**
+ * The overview's search entry. Ctrl+Enter emits `activate-new-instance` rather
+ * than activating the selected result.
+ *
+ * @version 51
+ */
+export class SearchEntry extends St.Entry {
+    $signals: SearchEntry.SignalSignatures;
+
+    // Signal handler methods
+    connect<S extends SearchEntry.SignalSignatures, K extends keyof S>(signal: K, callback: GObject.SignalCallback<this, S[K]>): number;
+    connect_after<S extends SearchEntry.SignalSignatures, K extends keyof S>(signal: K, callback: GObject.SignalCallback<this, S[K]>): number;
+
+    // Generic signal handler methods
+    connect(signal: string, callback: (...args: any[]) => any): number;
+    connect_after(signal: string, callback: (...args: any[]) => any): number;
+}
+
 export class MaxWidthBox extends St.BoxLayout {}
 
 export class SearchResult extends St.Button {
@@ -125,7 +150,6 @@ export class SearchResultsView extends St.BoxLayout {
     _doProviderSearch(provider: AppSearchProvider, previousResults: any[]): Promise<any[]>;
     _doSearch(): void;
     _onSearchTimeout(): void;
-    _onPan(action: any): void;
     _focusChildChanged(provider: AppSearchProvider): void;
     _ensureProviderDisplay(provider: AppSearchProvider): void;
     _clearDisplay(): void;