Skip to content

fix: match popup animation params to GNOME 51 - #149

Open
Rayzeq wants to merge 4 commits into
gjsify:fix/gnome-51-api-driftfrom
Rayzeq:fix/gnome-51-popup-menu
Open

Rayzeq wants to merge 4 commits into
gjsify:fix/gnome-51-api-driftfrom
Rayzeq:fix/gnome-51-popup-menu

Conversation

@Rayzeq

@Rayzeq Rayzeq commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

JumpLink and others added 4 commits August 29, 2026 09:05
GNOME 51 moves event handling off actor vfuncs and onto Clutter actions,
gestures and key binding pools. The shell classes stopped overriding
`vfunc_*_event` and grew signal handlers instead. Those vfuncs still
exist on `Clutter.Actor`, so nothing fails to compile. The declarations
just stopped describing the shell.

Checked against gnome-shell at tag 51.beta, module by module, for every
declared name that changed between 50.4 and 51.beta:

  appDisplay    BaseAppView/AppDisplay._onScroll now takes the
                ScrollController signal arguments; _onKeyPressEvent is a
                binding pool closure
  boxpointer    _muteKeys is a KeyController, _muteInput a ClickGesture
  calendar      vfunc_scroll_event -> _onScroll
  dialog        vfunc_event -> KeyController
  layout        HotCorner.vfunc_leave_event is gone
  messageList   URLHighlighter motion/leave -> MotionController;
                Message.vfunc_key_press_event -> _closeIfAllowed
  messageTray   _onNotificationKeyRelease -> binding pool
  modalDialog   vfunc_captured_event is gone
  search        new exported SearchEntry with activate-new-instance
  slider        scroll/key vfuncs -> _onScroll, _moveLeft, _moveRight
  backlight     SliderItem forwards vfunc_navigate_focus
  volume        _handleScrollEvent -> _onScroll + _handleScroll
  switcherPopup key/scroll vfuncs -> _onKeyPress, _onModifierChange,
                _onScroll
  userWidget    new showAvatar/hideAvatar

Everything added here carries `@version 51`, including the handlers
whose arguments 51 reshaped.
Checking these modules against 51.beta turned up a second group. These
names are absent at 50.4 as well, so gnome-shell dropped them in an
earlier cycle and they describe an API no supported shell has.

  appFavorites  _onFavsChanged
  calendar      _dndSwitch, _dndButton and the DoNotDisturbSwitch class
                behind them (the switch moved to quick settings)
  layout        HotCorner._entered, _onCornerEntered, _onCornerLeft,
                _setupFallbackCornerIfNeeded, _pendingLoadBackground
  messageList   URLHighlighter button press/release vfuncs,
                NotificationMessage._getIcon/_onUpdated,
                MediaMessage._secondaryBin/_closeButton
  messageTray   _onNotificationShow
  popupMenu     _motionEvent, _touchDragging
  search        _onPan
  slider        button press/release and touch vfuncs, startDragging,
                _endDragging, _motionEvent, scroll
  switcherPopup vfunc_button_press_event

Slider gains `step(nSteps)` in the same pass. It replaced
`scroll(event)`, `status/volume` calls it, and it was never declared. It
predates 51, so it carries no `@version` tag.

Only modules that GNOME 51 touched are in scope here. The rest of the
package has more of this; the PR description lists it.

@Totto16 Totto16 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on #146 (stack with the top being #147)

(I'll remove this after them being merged)

@JumpLink
JumpLink force-pushed the fix/gnome-51-api-drift branch 3 times, most recently from 3ed8e00 to d73143b Compare October 6, 2026 13:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants