feat(attributes): Replace fs_error in favor of error.type - #589
Merged
Lms24 merged 2 commits intoSep 9, 2026
Merged
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Descriptions
Names
Other
Bug Fixes 🐛
Internal Changes 🔧Deps
Names
Other
🤖 This preview updates automatically when you update the PR. |
JPeer264
force-pushed
the
jp/conv-fs-error-transform
branch
from
August 27, 2026 08:18
cc8d97b to
1a79e89
Compare
JPeer264
force-pushed
the
jp/conv-fs-error-transform
branch
2 times, most recently
from
August 27, 2026 16:21
f2dc3b3 to
c8b8890
Compare
JPeer264
force-pushed
the
jp/conv-fs-error-transform
branch
from
August 27, 2026 16:30
c8b8890 to
22456a2
Compare
JPeer264
force-pushed
the
jp/conv-fs-error-transform
branch
from
August 27, 2026 16:41
22456a2 to
062c32e
Compare
JPeer264
changed the base branch from
jp/conv-net-alias-fixes
to
jp/conv-gen-ai-tool-definitions-alias
August 27, 2026 16:45
JPeer264
force-pushed
the
jp/conv-fs-error-transform
branch
from
August 27, 2026 16:49
062c32e to
10feab1
Compare
Member
Author
|
|
JPeer264
force-pushed
the
jp/conv-fs-error-transform
branch
from
August 27, 2026 17:29
10feab1 to
25c4886
Compare
Lms24
approved these changes
Aug 28, 2026
Lms24
left a comment
Member
There was a problem hiding this comment.
thanks! (PR title needs a small adjustment but otherwise lgtm!)
fs_error into error.typefs_error in favor of error.type
JPeer264
marked this pull request as ready for review
August 28, 2026 11:49
JPeer264
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
August 28, 2026 11:49
JPeer264
force-pushed
the
jp/conv-fs-error-transform
branch
from
August 28, 2026 11:49
25c4886 to
a30638c
Compare
JPeer264
force-pushed
the
jp/conv-fs-error-transform
branch
from
August 28, 2026 12:12
a30638c to
46a6993
Compare
JPeer264
force-pushed
the
jp/conv-fs-error-transform
branch
from
August 28, 2026 12:26
46a6993 to
c0967dc
Compare
JPeer264
force-pushed
the
jp/conv-fs-error-transform
branch
from
September 7, 2026 13:51
2b56ad3 to
000ee1d
Compare
JPeer264
force-pushed
the
jp/conv-fs-error-transform
branch
from
September 9, 2026 09:28
000ee1d to
5ac960e
Compare
`fs_error` already replaces onto `error.type`, but neither side named the other, so the two did not form an alias group. The value changes from the full error message to the syscall error code, so the old value cannot be copied over. The deprecation therefore stays `_status: null` and keeps `error.type` as the replacement. The reason now says why the value cannot be copied. Replaced by getsentry/sentry-javascript#23401 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`fs_error` holds the full file system error message, for example `ENOENT: no such file or directory, open '/tmp/missing.txt'`. v11 of the JavaScript SDK reports the syscall error code on `error.type` instead, so the value has to be shortened, not just renamed. Adds the `fs_error_to_error_type` transformation and sets `fs_error` to `_status: "transform"`. No alias is added, matching how `gen_ai.request.messages` is modelled: an alias declares two names for the same value, which is no longer true once the value changes. Replaced by getsentry/sentry-javascript#23401 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
jp/conv-fs-error-transform
branch
from
September 9, 2026 18:02
5ac960e to
f120c87
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs_errorheld the full file system error message, for exampleENOENT: no such file or directory, open '/tmp/missing.txt'. v11 of the JavaScript SDK reports the syscall error code onerror.typeinstead, so the value has to be shortened, not just renamed.Adds the
fs_error_to_error_typetransformation and setsfs_errorto_status: "transform".No alias is added, matching how
gen_ai.request.messagesis modelled: an alias declares two names for the same value, which is no longer true once the value changes.Replaced by getsentry/sentry-javascript#23401