Skip to content

feat(attributes): Replace fs_error in favor of error.type - #589

Merged
Lms24 merged 2 commits into
jp/conv-gen-ai-tool-definitions-aliasfrom
jp/conv-fs-error-transform
Sep 9, 2026
Merged

feat(attributes): Replace fs_error in favor of error.type#589
Lms24 merged 2 commits into
jp/conv-gen-ai-tool-definitions-aliasfrom
jp/conv-fs-error-transform

Conversation

@JPeer264

Copy link
Copy Markdown
Member

fs_error held the full file system error message, for example ENOENT: no such file or directory, open '/tmp/missing.txt'. v11 of the JavaScript SDK reports the syscall error code on error.type instead, so the value has to be shortened, not just renamed.

Adds the fs_error_to_error_type transformation and sets fs_error to _status: "transform".

No alias is added, matching how gen_ai.request.messages is modelled: an alias declares two names for the same value, which is no longer true once the value changes.

Replaced by getsentry/sentry-javascript#23401

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Replace fs_error in favor of error.type by JPeer264 in #589
  • Replace fs_error in favor of error.type by JPeer264 in #589
  • Add sveltekit.* attributes emitted by SvelteKit's native spans by Lms24 in #611
  • Add browser.navigation.type, move navigation.* to router.navigation.* by logaretm in #600
  • Add langchain.chain.name (deprecated) in favor of gen_ai.pipeline.name by RulaKhaled in #599
  • Add browser.paint.type by Lms24 in #606

Descriptions

  • Add more fine grained function.gcp span description rules by Lms24 in #624
  • Add graphql span description rules by Lms24 in #616

Names

  • Add FAAS function span name and description rules by Lms24 in #617
  • Add function span name and description rules by Lms24 in #618
  • Add browser.* span name and description rules by Lms24 in #607
  • Add cache span name rules by Lms24 in #605

Other

  • (op) Add mobile OTA update span operations by antonis in #540
  • (search-attributes) Add search attribute names by nsdeschenes in #610

Bug Fixes 🐛

  • (descriptions) Add graphql-enhanced http.client span description template by Lms24 in #613

Internal Changes 🔧

Deps

  • Bump astro from 7.1.0 to 7.2.8 by dependabot in #628
  • Bump sharp from 0.35.3 to 0.35.4 by dependabot in #630
  • Bump js-yaml from 4.3.1 to 4.3.2 by dependabot in #631
  • Bump svgo from 4.0.2 to 4.1.0 by dependabot in #627
  • Bump browserslist from 4.28.2 to 4.28.8 by dependabot in #614
  • Bump fast-uri from 3.1.5 to 3.1.7 by dependabot in #612

Names

  • Clarify GraphQL OTel divergence note by andreiborza in #626
  • Add OTel divergence note for graphql span names by Lms24 in #615

Other

  • (attributes) Clarify parameter name casing by Lms24 in #632
  • (deps-dev) Bump vitest from 4.1.9 to 4.1.11 by dependabot in #629
  • (descriptions) Fix http.client span description example by Lms24 in #603

🤖 This preview updates automatically when you update the PR.

@JPeer264
JPeer264 force-pushed the jp/conv-fs-error-transform branch from cc8d97b to 1a79e89 Compare August 27, 2026 08:18
@JPeer264
JPeer264 force-pushed the jp/conv-fs-error-transform branch 2 times, most recently from f2dc3b3 to c8b8890 Compare August 27, 2026 16:21
@JPeer264
JPeer264 force-pushed the jp/conv-fs-error-transform branch from c8b8890 to 22456a2 Compare August 27, 2026 16:30
@JPeer264
JPeer264 force-pushed the jp/conv-fs-error-transform branch from 22456a2 to 062c32e Compare August 27, 2026 16:41
@JPeer264
JPeer264 changed the base branch from jp/conv-net-alias-fixes to jp/conv-gen-ai-tool-definitions-alias August 27, 2026 16:45
@JPeer264
JPeer264 force-pushed the jp/conv-fs-error-transform branch from 062c32e to 10feab1 Compare August 27, 2026 16:49
@JPeer264

JPeer264 commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

we don't do transforms (Edit: but we keep the deprecation)

@JPeer264 JPeer264 closed this Aug 27, 2026
@JPeer264 JPeer264 reopened this Aug 27, 2026
@JPeer264
JPeer264 force-pushed the jp/conv-fs-error-transform branch from 10feab1 to 25c4886 Compare August 27, 2026 17:29

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! (PR title needs a small adjustment but otherwise lgtm!)

@JPeer264 JPeer264 changed the title feat(attributes): Transform fs_error into error.type feat(attributes): Replace fs_error in favor of error.type Aug 28, 2026
@JPeer264
JPeer264 marked this pull request as ready for review August 28, 2026 11:49
@JPeer264
JPeer264 requested review from a team, cleptric, mjq and nsdeschenes as code owners August 28, 2026 11:49
@JPeer264
JPeer264 force-pushed the jp/conv-fs-error-transform branch from 25c4886 to a30638c Compare August 28, 2026 11:49
Comment thread model/attributes/fs_error.json Outdated
@JPeer264
JPeer264 force-pushed the jp/conv-fs-error-transform branch from a30638c to 46a6993 Compare August 28, 2026 12:12
@JPeer264
JPeer264 force-pushed the jp/conv-fs-error-transform branch from 46a6993 to c0967dc Compare August 28, 2026 12:26
Comment thread model/attributes/fs_error.json Outdated
@JPeer264
JPeer264 requested a review from a team as a code owner September 7, 2026 12:03
@JPeer264
JPeer264 force-pushed the jp/conv-fs-error-transform branch from 2b56ad3 to 000ee1d Compare September 7, 2026 13:51
@JPeer264
JPeer264 force-pushed the jp/conv-fs-error-transform branch from 000ee1d to 5ac960e Compare September 9, 2026 09:28
JPeer264 and others added 2 commits September 9, 2026 20:00
`fs_error` already replaces onto `error.type`, but neither side named the
other, so the two did not form an alias group.

The value changes from the full error message to the syscall error code,
so the old value cannot be copied over. The deprecation therefore stays
`_status: null` and keeps `error.type` as the replacement. The reason now
says why the value cannot be copied.

Replaced by getsentry/sentry-javascript#23401

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`fs_error` holds the full file system error message, for example
`ENOENT: no such file or directory, open '/tmp/missing.txt'`. v11 of the
JavaScript SDK reports the syscall error code on `error.type` instead, so
the value has to be shortened, not just renamed.

Adds the `fs_error_to_error_type` transformation and sets `fs_error` to
`_status: "transform"`.

No alias is added, matching how `gen_ai.request.messages` is modelled: an
alias declares two names for the same value, which is no longer true once
the value changes.

Replaced by getsentry/sentry-javascript#23401

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Lms24
Lms24 force-pushed the jp/conv-fs-error-transform branch from 5ac960e to f120c87 Compare September 9, 2026 18:02
@Lms24
Lms24 merged commit 0e447f3 into main Sep 9, 2026
24 of 25 checks passed
@Lms24
Lms24 deleted the jp/conv-fs-error-transform branch September 9, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants