Skip to content

fix(attributes): Remove accidentally merged attribute transformation - #638

Merged
Lms24 merged 4 commits into
mainfrom
lms/fix-transform-removal
Sep 10, 2026
Merged

fix(attributes): Remove accidentally merged attribute transformation#638
Lms24 merged 4 commits into
mainfrom
lms/fix-transform-removal

Conversation

@Lms24

@Lms24 Lms24 commented Sep 10, 2026

Copy link
Copy Markdown
Member

#589 initially introduced an attribute transformation but we decide it to remove that in favour of a hard null replacement without automatic rewriting. This was implemented but through the rebases, got lost again, so we ended up merging the transformation. My bad.

@Lms24
Lms24 requested review from a team, cleptric, mjq and nsdeschenes as code owners September 10, 2026 14:32
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (attributes) Add cache.item_age and cache.tags by s1gr1d in #637

Bug Fixes 🐛

  • (attributes) Remove accidentally merged attribute transformation by Lms24 in #638

🤖 This preview updates automatically when you update the PR.

@Lms24 Lms24 self-assigned this Sep 10, 2026
Comment thread model/attributes/fs_error.json
@Lms24
Lms24 enabled auto-merge (squash) September 10, 2026 14:41
@Lms24
Lms24 merged commit 7802ebd into main Sep 10, 2026
17 checks passed
@Lms24
Lms24 deleted the lms/fix-transform-removal branch September 10, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants