Skip to content

fix: add maxun browser image #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RohitR311 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: add maxun browser image #1114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,13 @@ services:
- backend

browser:
build:
context: .
dockerfile: browser/Dockerfile
args:
BROWSER_WS_PORT: ${BROWSER_WS_PORT:-3001}
BROWSER_HEALTH_PORT: ${BROWSER_HEALTH_PORT:-3002}
# build:
# context: .
# dockerfile: browser/Dockerfile
# args:
# BROWSER_WS_PORT: ${BROWSER_WS_PORT:-3001}
# BROWSER_HEALTH_PORT: ${BROWSER_HEALTH_PORT:-3002}
image: getmaxun/maxun-browser:latest
Comment on lines +78 to +84

@coderabbitai coderabbitai Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify the prebuilt Docker image exists and check basic metadata

echo "=== Checking if image exists on Docker Hub ==="
curl -s "https://hub.docker.com/v2/repositories/getmaxun/maxun-browser/tags/latest" | jq -r '.name, .last_updated'

echo -e "\n=== Checking local Dockerfile build args usage ==="
if [ -f browser/Dockerfile ]; then
  echo "Found browser/Dockerfile, checking ARG usage:"
  grep -n "ARG BROWSER_WS_PORT\|ARG BROWSER_HEALTH_PORT\|ENV BROWSER_WS_PORT\|ENV BROWSER_HEALTH_PORT" browser/Dockerfile || echo "No matching ARG/ENV declarations found"
else
  echo "browser/Dockerfile not found (this is expected per PR objectives)"
fi

echo -e "\n=== Checking server.ts port usage ==="
if [ -f browser/server.ts ]; then
  grep -n "BROWSER_WS_PORT\|BROWSER_HEALTH_PORT" browser/server.ts | head -10
fi

Repository: getmaxun/maxun

Length of output: 1124

The prebuilt image getmaxun/maxun-browser:latest does not exist on Docker Hub.

The docker-compose.yml references a prebuilt image that is not available. This will cause Docker to fail when attempting to pull it. The local build configuration has been commented out, leaving no valid way to obtain the image.

Either:

  • Push the prebuilt image to Docker Hub at getmaxun/maxun-browser:latest, or
  • Restore the local build configuration (lines 78-83) to rebuild the image from source
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docker-compose.yml` around lines 78 - 84, The docker-compose.yml file
references a non-existent prebuilt image getmaxun/maxun-browser:latest while the
local build configuration has been commented out. Uncomment the build block
(context, dockerfile, and args with BROWSER_WS_PORT and BROWSER_HEALTH_PORT) for
the browser service and remove the image reference line so that Docker builds
the image locally from the browser/Dockerfile instead of attempting to pull a
non-existent image from Docker Hub.

ports:
- "${BROWSER_WS_PORT:-3001}:${BROWSER_WS_PORT:-3001}"
- "${BROWSER_HEALTH_PORT:-3002}:${BROWSER_HEALTH_PORT:-3002}"
Expand Down