Skip to content

fix: add maxun browser image#1114

Open
RohitR311 wants to merge 1 commit into
developfrom
browser-fix
Open

fix: add maxun browser image#1114
RohitR311 wants to merge 1 commit into
developfrom
browser-fix

Conversation

@RohitR311

@RohitR311 RohitR311 commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

What this PR does?

Fixes the bug wherein the docker build resulted in an error if the browser directory from the repo was not present.

Fixes: #1112

Summary by CodeRabbit

  • Chores
    • Updated the browser service deployment configuration to use a prebuilt Docker image instead of local builds.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The browser service in docker-compose.yml is updated to pull the prebuilt image getmaxun/maxun-browser:latest from Docker Hub instead of building locally from browser/Dockerfile. The prior build configuration is commented out; all runtime settings remain unchanged.

Changes

Browser Service Image Switch

Layer / File(s) Summary
Replace local build with prebuilt image
docker-compose.yml
The build block (context, dockerfile, args BROWSER_WS_PORT/BROWSER_HEALTH_PORT) is commented out and replaced with image: getmaxun/maxun-browser:latest. All runtime configuration is preserved.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A Dockerfile sat, collecting dust,
"Just pull from the Hub," said the rabbit, robust.
No building from scratch, no args to pass through,
One line does the trick — image: will do!
Hops saved, time gained, the compose file gleams.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: add maxun browser image' directly summarizes the main change: replacing a local Dockerfile build with a prebuilt image in docker-compose.yml to resolve the Docker build failure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch browser-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
docker-compose.yml (1)

84-84: ⚖️ Poor tradeoff

Pin the image to a specific version instead of using :latest.

Using the :latest tag creates stability and reproducibility risks:

  • Different environments may pull different versions of the image
  • No ability to roll back to a previous version if issues arise
  • Difficult to debug when the image changes unexpectedly
  • Build cache invalidation can cause surprising behavior

Consider using a specific version tag (e.g., getmaxun/maxun-browser:v1.0.0 or a commit SHA digest).

📌 Recommended approach for version pinning
-    image: getmaxun/maxun-browser:latest
+    image: getmaxun/maxun-browser:v1.0.0  # or use digest: getmaxun/maxun-browser@sha256:...
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docker-compose.yml` at line 84, The image specification for
getmaxun/maxun-browser is currently using the `:latest` tag which causes
reproducibility and stability issues. Replace the `:latest` tag with a specific
version tag (such as a semantic version like `v1.0.0` or a commit SHA digest) to
ensure the same image is pulled consistently across different environments and
to maintain the ability to rollback if needed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docker-compose.yml`:
- Around line 78-84: The docker-compose.yml file references a non-existent
prebuilt image getmaxun/maxun-browser:latest while the local build configuration
has been commented out. Uncomment the build block (context, dockerfile, and args
with BROWSER_WS_PORT and BROWSER_HEALTH_PORT) for the browser service and remove
the image reference line so that Docker builds the image locally from the
browser/Dockerfile instead of attempting to pull a non-existent image from
Docker Hub.

---

Nitpick comments:
In `@docker-compose.yml`:
- Line 84: The image specification for getmaxun/maxun-browser is currently using
the `:latest` tag which causes reproducibility and stability issues. Replace the
`:latest` tag with a specific version tag (such as a semantic version like
`v1.0.0` or a commit SHA digest) to ensure the same image is pulled consistently
across different environments and to maintain the ability to rollback if needed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 30398a60-7173-4487-b645-076af22c598b

📥 Commits

Reviewing files that changed from the base of the PR and between d581502 and bf1be9a.

📒 Files selected for processing (1)
  • docker-compose.yml

Comment thread docker-compose.yml
Comment on lines +78 to +84
# build:
# context: .
# dockerfile: browser/Dockerfile
# args:
# BROWSER_WS_PORT: ${BROWSER_WS_PORT:-3001}
# BROWSER_HEALTH_PORT: ${BROWSER_HEALTH_PORT:-3002}
image: getmaxun/maxun-browser:latest

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify the prebuilt Docker image exists and check basic metadata

echo "=== Checking if image exists on Docker Hub ==="
curl -s "https://hub.docker.com/v2/repositories/getmaxun/maxun-browser/tags/latest" | jq -r '.name, .last_updated'

echo -e "\n=== Checking local Dockerfile build args usage ==="
if [ -f browser/Dockerfile ]; then
  echo "Found browser/Dockerfile, checking ARG usage:"
  grep -n "ARG BROWSER_WS_PORT\|ARG BROWSER_HEALTH_PORT\|ENV BROWSER_WS_PORT\|ENV BROWSER_HEALTH_PORT" browser/Dockerfile || echo "No matching ARG/ENV declarations found"
else
  echo "browser/Dockerfile not found (this is expected per PR objectives)"
fi

echo -e "\n=== Checking server.ts port usage ==="
if [ -f browser/server.ts ]; then
  grep -n "BROWSER_WS_PORT\|BROWSER_HEALTH_PORT" browser/server.ts | head -10
fi

Repository: getmaxun/maxun

Length of output: 1124


The prebuilt image getmaxun/maxun-browser:latest does not exist on Docker Hub.

The docker-compose.yml references a prebuilt image that is not available. This will cause Docker to fail when attempting to pull it. The local build configuration has been commented out, leaving no valid way to obtain the image.

Either:

  • Push the prebuilt image to Docker Hub at getmaxun/maxun-browser:latest, or
  • Restore the local build configuration (lines 78-83) to rebuild the image from source
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docker-compose.yml` around lines 78 - 84, The docker-compose.yml file
references a non-existent prebuilt image getmaxun/maxun-browser:latest while the
local build configuration has been commented out. Uncomment the build block
(context, dockerfile, and args with BROWSER_WS_PORT and BROWSER_HEALTH_PORT) for
the browser service and remove the image reference line so that Docker builds
the image locally from the browser/Dockerfile instead of attempting to pull a
non-existent image from Docker Hub.

@RohitR311 RohitR311 added the Type: Bug Something isn't working label Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Documentation step 8 - Errors occur

1 participant