Skip to content

CIRC-2641: fix closedLoanWithOpenFee() test method building an open loan #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slaemmer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CIRC-2641: fix closedLoanWithOpenFee() test method building an open loan #1685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
* Fix flaky tests ([CIRC-2633](https://folio-org.atlassian.net/browse/CIRC-2633))
* Refactor item location handling to use locationRepository directly for effective location retrieval ([CIRC-2538](https://folio-org.atlassian.net/browse/CIRC-2538))
* Fail on startup if Kafka config is invalid ([CIRC-2003](https://folio-org.atlassian.net/browse/CIRC-2003))
* Fix loan status in `AnonymizeLoansTests` fixture for closed loans with open fees ([CIRC-2641](https://folio-org.atlassian.net/browse/CIRC-2641))

## 24.5.0 2026-04-14
* Allow HTTP Connection Pool to be Configurable ([CIRC-2279](https://folio-org.atlassian.net/browse/CIRC-2279))
Expand Down
7 changes: 4 additions & 3 deletions src/test/java/org/folio/circulation/domain/anonymization/AnonymizeLoansTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,12 @@ void doNotAnonymizeOpenLoanWithNoFees() {
}

@Test
void doNotAnonymizeClosedLoanWithOpenFees() {
void anonymizeClosedLoanWithOpenFees() {
final var segregatedLoans = checker.segregateLoans(List.of(closedLoanWithOpenFee()));

assertThat(segregatedLoans.size(), is(1));
assertThat(loansNotAnonymizedImmediately(segregatedLoans).size(), is(1));
// Fees and fines are ignored when loans with fees should not be treated differently
assertThat(anonymizedLoans(segregatedLoans).size(), is(1));
}

@Test
Expand Down Expand Up @@ -381,7 +382,7 @@ private Loan closedLoanWithClosedFee(ZonedDateTime feeClosedDate) {
}

private Loan closedLoanWithOpenFee() {
return loan("Open", null)
return loan("Closed", null)
.withAccounts(List.of(openFee()));
}

Expand Down
Loading