Conversation
The fixture built a loan with status "Open", so five tests silently exercised the open-loan path. Correcting it to "Closed" exposed that WhenAnonymizingAllLoansImmediatelyTests.doNotAnonymizeClosedLoanWithOpenFees asserted the opposite of the module's behaviour: with treatLoansWithFeesAndFinesDifferently=false, AnonymizeLoansImmediatelyChecker only checks loan.isClosed() and ignores fees and fines. Renamed the test and flipped its assertion to match.
|
alexanderkurash
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CIRC-2641
Purpose
AnonymizeLoansTests.closedLoanWithOpenFee()built a loan with status"Open"instead of"Closed". A few tests used this and passed accidentally. One asserted the opposite of the actual behavior. Closed loans should be anonymized without ever checking fees / fines according to here.Approach
"Closed".WhenAnonymizingAllLoansImmediatelyTests.doNotAnonymizeClosedLoanWithOpenFeestoanonymizeClosedLoanWithOpenFeesand corrected its assertionProduction code is unchanged; the remaining tests using the method pass unmodified because their configurations set
treatLoansWithFeesAndFinesDifferently = true(or use manual anonymization), so they were already reaching a fees-aware checker.