fix: correct Llama model name, handle JSON spacing errors, and prevent mode conflicts - #5
fix: correct Llama model name, handle JSON spacing errors, and prevent mode conflicts#5minsing-jin wants to merge 5 commits into
Conversation
…Llama-3.1-70B-Instruct.
…rompt instructions.
…_prompt_generate, we can’t choose between do_prompt_generate, do_inference, or do_eval.
|
Hi @minsing-jin! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
yjbang
left a comment
There was a problem hiding this comment.
Thanks for the fixes and suggestions!
What I did
1. Model name error in
longwiki_main.pycode 66 line2. Fix error caused by incorrect spacing when the model doesn’t follow prompt instructions at
longwiki_utils.pycheck_validityfunction at 122 line.3. Prevent mode selection conflict at
precise_wikiqa.pyat 269 line.