Skip to content

fix: correct Llama model name, handle JSON spacing errors, and prevent mode conflicts - #5

Open
minsing-jin wants to merge 5 commits into
facebookresearch:mainfrom
minsing-jin:Feature/#5
Open

fix: correct Llama model name, handle JSON spacing errors, and prevent mode conflicts#5
minsing-jin wants to merge 5 commits into
facebookresearch:mainfrom
minsing-jin:Feature/#5

Conversation

@minsing-jin

@minsing-jin minsing-jin commented Oct 28, 2025

Copy link
Copy Markdown

What I did

1. Model name error in longwiki_main.py code 66 line

  • Model name error. Huggingface lamma 3.1 70B model name is meta-llama/Llama-3.1-70B-Instruct.
image

2. Fix error caused by incorrect spacing when the model doesn’t follow prompt instructions at longwiki_utils.py check_validity function at 122 line.

  • Fix error caused by incorrect spacing when the model doesn’t follow prompt json instructions.
image

3. Prevent mode selection conflict at precise_wikiqa.py at 269 line.

  • If QA_OUTPUT_PATH is specified in condition of do_prompt_generate, we can’t choose between do_prompt_generate, do_inference, or do_eval
image

@meta-cla

meta-cla Bot commented Oct 28, 2025

Copy link
Copy Markdown

Hi @minsing-jin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 28, 2025
@minsing-jin minsing-jin changed the title Model name error and QA_OUTPUT_PATH fix: correct Llama model name, handle JSON spacing errors, and prevent mode conflicts Oct 28, 2025

@yjbang yjbang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes and suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants