common:setup: clone common_bench directly to .local, drop install_common.sh#100
Merged
common:setup: clone common_bench directly to .local, drop install_common.sh#100
Conversation
…mon.sh Instead of cloning to setup/ and then copying to .local/ via install_common.sh, clone directly to .local/. All downstream jobs already source .local/bin/env.sh, so no downstream changes are needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the GitLab CI bootstrap by cloning common_bench directly into .local/ (the location already used by downstream jobs) and removing the intermediate setup/ clone + copy step.
Changes:
- Update
common:setuptogit clonecommon_benchinto.localinstead ofsetup. - Drop
./setup/bin/install_common.shinvocation and source.local/bin/env.shdirectly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
veprbl
approved these changes
Apr 28, 2026
wdconinc
added a commit
to eic/common_bench
that referenced
this pull request
Apr 30, 2026
This script existed solely to copy common_bench's bin/, include/, and share/ into $LOCAL_PREFIX. Both detector_benchmarks and physics_benchmarks now clone common_bench directly to .local/ (the LOCAL_PREFIX), making this install step unnecessary. Depends on: eic/detector_benchmarks#286 eic/physics_benchmarks#100 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wdconinc
added a commit
to eic/common_bench
that referenced
this pull request
May 1, 2026
This script existed solely to copy common_bench's bin/, include/, and share/ into $LOCAL_PREFIX. Both detector_benchmarks and physics_benchmarks now clone common_bench directly to .local/ (the LOCAL_PREFIX), making this install step unnecessary. Depends on: eic/detector_benchmarks#286 eic/physics_benchmarks#100 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_common.shexists solely to copysetup/ → .local/. All downstream jobs already source.local/bin/env.sh—setup/is never an artifact.By cloning directly to
.local/, the separate copy step is eliminated andinstall_common.shbecomes dead code.Change
No downstream jobs are affected — they all already source
.local/bin/env.sh.