Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This script existed solely to copy common_bench's bin/, include/, and share/ into $LOCAL_PREFIX. Both detector_benchmarks and physics_benchmarks now clone common_bench directly to .local/ (the LOCAL_PREFIX), making this install step unnecessary. Depends on: eic/detector_benchmarks#286 eic/physics_benchmarks#100 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wdconinc
force-pushed
the
remove-install-common-sh
branch
from
e6b8749 to
fe63b22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/install_common.shexisted solely to copy common_bench'sbin/,include/, andshare/directories into$LOCAL_PREFIX. Both benchmark repos now clone common_bench directly to.local/(which ISLOCAL_PREFIX), making this copy step unnecessary.Dependencies
This should merge after:
source setup/bin/install_common.shcall