Skip to content

docker-users update #25520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aevesdocker merged 3 commits into from
Jul 9, 2026
+10 −0
Merged

docker-users update #25520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
437e867
docker-users update
aevesdocker Jul 8, 2026
6cd1272
tidy
aevesdocker Jul 8, 2026
9f9cb92
fix
aevesdocker Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions content/manuals/desktop/setup/install/windows-install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,12 @@ If using all-users installation and your administrator account is different to y
$ net localgroup docker-users <user> /add
```

> [!WARNING]
>
> Membership in `docker-users` grants access to the Docker daemon socket, which is equivalent to granting administrative privileges on the host. Only add users who require access to Windows containers or Hyper-V VM management. For Linux containers using the WSL 2 backend, this group membership is not required. See [Protect the Docker daemon socket](/manuals/engine/security/protect-access.md) for more information.

@docker-agent docker-agent Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] Broken internal link — missing /manuals/ prefix

The link to Protect the Docker daemon socket uses the path /engine/security/protect-access/, but the canonical internal link format for this repo is /manuals/<path>.md. The companion callout added in faq.md (in this same PR) correctly uses /manuals/engine/security/protect-access.md, and other existing files (e.g. content/manuals/engine/daemon/remote-access.md) also use the /manuals/… format.

The /engine/security/… path would only work if Hugo has an alias redirect for that URL. Without one, the link will 404.

Suggested fix:

See [Protect the Docker daemon socket](/manuals/engine/security/protect-access.md) for more information.


@docker-agent docker-agent Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LOW] Link text is a full question sentence (~17 words), exceeding the ~5-word style guide recommendation

The cross-reference link text uses the entire FAQ heading as its anchor: "Why isn't the docker-users group populated when the MSI is installed with Intune or another MDM solution?". The Docker style guide recommends link text of around five words, front-loaded with important terms, to aid scannability. A shorter alternative such as "docker-users group not populated via MDM" conveys the same meaning at a glance.

If you're deploying via MDM (such as Intune) and the `docker-users` group isn't populated automatically, see [Why isn't the `docker-users` group populated when the MSI is installed with Intune or another MDM solution?](/manuals/enterprise/enterprise-deployment/faq.md#why-isnt-the-docker-users-group-populated-when-the-msi-is-installed-with-intune-or-another-mdm-solution).

See the [Installer flags](#installer-flags) section to see what flags the `install` command accepts.

> [!NOTE]
Expand Down
4 changes: 4 additions & 0 deletions content/manuals/enterprise/enterprise-deployment/faq.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ As a workaround, you can create a script that runs in the context of the user ac

The script would be responsible for ensuring the `docker-users` group exists and populating it with the correct user.

> [!WARNING]

@docker-agent docker-agent Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LOW] Callout closing phrase differs from the matching callout in windows-install.md

This callout ends with "for further information" while the identical callout added in content/manuals/desktop/setup/install/windows-install.md ends with "for more information". The two callouts are otherwise near-identical duplicates; the inconsistent phrasing is a minor polish issue. The style guide also treats trailing meta-phrases like "for more/further information" as unnecessary — the link itself is sufficient.

>
> Membership in `docker-users` grants access to the Docker daemon socket, which is equivalent to granting administrative privileges on the host. Only add users who require access to Windows containers or Hyper-V VM management. For Linux containers using the WSL 2 backend, this group membership is not required. See [Protect the Docker daemon socket](/manuals/engine/security/protect-access.md) for further information.

@docker-agent docker-agent Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LOW] Inconsistent phrasing between companion callouts

This callout ends with "for further information", while the nearly identical callout added in windows-install.md (in this same PR) ends with "for more information". Since both callouts contain the same warning text, they should use the same closing phrase for consistency.

Suggested fix: Change "for further information" to "for more information" to match windows-install.md.


Here's an example script that creates the `docker-users` group if needed and adds the current user to it (requirements may vary depending on environment):

```powershell
Expand Down